Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons missing in 'npm run export' PDFs #1084

Closed
JPustkuchen opened this issue Aug 16, 2023 · 10 comments
Closed

Icons missing in 'npm run export' PDFs #1084

JPustkuchen opened this issue Aug 16, 2023 · 10 comments

Comments

@JPustkuchen
Copy link
Contributor

JPustkuchen commented Aug 16, 2023

To Reproduce

Run

  1. npm init slidev
  2. cd into the directory
  3. npm i -D playwright-chromium
  4. npm run export

as documented here: https://sli.dev/guide/exporting.html#multiple-entries

Actual PDF content page 2 display in the PDF:
grafik
(Iicons broken!)

Expected (and acutal running npm run dev opened in latest Chrome:
grafik

Desktop (please complete the following information):

  • OS: WSL Ubuntu on Windows 11
  • Browser: Chrome
  • Slidev version: 0.42.8
@antfu
Copy link
Member

antfu commented Sep 7, 2023

We temporarily close this due to the lack of enough information.
Please provide a minimal reproduction to reopen the issue.
Thanks.

Why reproduction is required

@antfu antfu closed this as completed Sep 7, 2023
@JPustkuchen
Copy link
Contributor Author

JPustkuchen commented Sep 7, 2023

Hi @antfu sorry but I think I provided three simple steps based on the default setup:

Run

npm init slidev
npm i -D playwright-chromium
npm run export

...

So why is this closed?

(Taking this personally 😛 )

@antfu
Copy link
Member

antfu commented Sep 7, 2023

I would suggest you try debug it on your side, it might have something to do with windows, chrome, local fonts, or your local playwright setup etc.

As I can't reproduce it (I am on a mac), I don't see a way to help you. Also it's unlikely a Slidev issue (as we just display the emoji, or actually we didn't do anything special to handle them).

@JPustkuchen
Copy link
Contributor Author

Thanks for the instant feedback @antfu - but shouldn't we keep it open then at least for other windows users?

I'll ask a teammate to try the same on his Windows 11 machine. FYI: My setup was vanilla, I only installed these tools for Slidev, without modifications, so I'm quite sure I won't be the only one with this problem.

If it happens for all Windows users, perhaps it's at least worth a FAQ entry?

I'll reply here after the test.

@antfu
Copy link
Member

antfu commented Sep 7, 2023

I am sorry that I need to aggressively close issues to keep the maintenance work in control.

I'd be happy to have a FAQ if you find the solution and willing to open a PR adding it.

@JPustkuchen
Copy link
Contributor Author

JPustkuchen commented Sep 7, 2023

Totally understand, yes.

I'll try to help!

@JPustkuchen
Copy link
Contributor Author

@joshsedl
Copy link

joshsedl commented Sep 7, 2023

Can not reproduce using :

  • Slidev 0.43.1
  • Windows 11
  • WSL2 1.2.3.0

@JPustkuchen
Copy link
Contributor Author

I can confirm it's working on @joshsedl's setup, which is quite similar to mine. Like me he ran the steps on WLS2 on Windows 11

I also just tried upgrading to Slidev 0.43.1 with no change. "playwright-chromium": "^1.37.1" is also up to date.

So it must be something locally indeed, perhaps within playwright or its dependencies. I have no clue. If the same should happen to anyone else, please report here.

I'd be really happy to find the deeper reasons. Until I'm the only one reporting this, let's keep this closed. Thank you all!

@JPustkuchen
Copy link
Contributor Author

@joshsedl just had the great idea to run
npx playwright install-deps once again and you won't believe... NOW IT WORKS! :)

I guess it overwrote / updated something. <3

Hopefully this helps others running into the same situation in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants