Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: HMR on slide facades #1913

Merged
merged 1 commit into from
Oct 26, 2024
Merged

fix: HMR on slide facades #1913

merged 1 commit into from
Oct 26, 2024

Conversation

KermanX
Copy link
Member

@KermanX KermanX commented Oct 25, 2024

fix #1910

Facade modules like /@slidev/slides/3 should be HMRed when it's target source module is changed

Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for slidev ready!

Name Link
🔨 Latest commit 3dfcf8a
🔍 Latest deploy log https://app.netlify.com/sites/slidev/deploys/671ba08116a12500082a4a05
😎 Deploy Preview https://deploy-preview-1913--slidev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Oct 25, 2024

Open in Stackblitz

create-slidev

pnpm add https://pkg.pr.new/slidevjs/slidev/create-slidev@1913

@slidev/client

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/client@1913

create-slidev-theme

pnpm add https://pkg.pr.new/slidevjs/slidev/create-slidev-theme@1913

@slidev/parser

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/parser@1913

@slidev/cli

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/cli@1913

@slidev/types

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/types@1913

commit: 3dfcf8a

@antfu antfu merged commit 5666d07 into slidevjs:main Oct 26, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HMR does not work when new slides are added to imported slides using src:
2 participants