Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring main website up to date with main branch #142

Closed
slmnio opened this issue Oct 12, 2022 · 4 comments
Closed

Bring main website up to date with main branch #142

slmnio opened this issue Oct 12, 2022 · 4 comments
Labels
section: server Relates to server or node scripts section: website Relates to website pages

Comments

@slmnio
Copy link
Owner

slmnio commented Oct 12, 2022

The main slmn.gg site uses the latest release which is over 100 commits old now. I've been hesitant to bring so many new changes to live, but it's about time.

The big change is that authentication is now live on the development server. Most of the return paths look like they should be fine, but it's nothing some quick patch releases couldn't fix.

Major changes coming to 1.17 are:

  • Discord authentication
  • New action system for API requests
  • Overhauls to the auction system (even more are needed)
  • Lots of new overlay changes
  • Lots of new internal data systems changes (though since the data server is always the latest commit it's been in production for a while)
  • Hero recolouring beta

This issue will track the deployment of the new version to see if anything breaks.

@slmnio slmnio added section: website Relates to website pages section: server Relates to server or node scripts labels Oct 12, 2022
@slmnio
Copy link
Owner Author

slmnio commented Oct 12, 2022

First release only updated the dev server, a force redelivery looks like it's done the job. Now to test things to see if it breaks.

@slmnio
Copy link
Owner Author

slmnio commented Oct 12, 2022

There's an issue in the server/src/discord/auth.js file with a TODO which is required for this to work. It needs to do a similar thing to the client side to send over the correct redirect_uri in the request

@slmnio
Copy link
Owner Author

slmnio commented Oct 12, 2022

Maybe fixed in 8f30b75

@slmnio
Copy link
Owner Author

slmnio commented Oct 12, 2022

Confirmed fixed, now to check other parts of the website to see if there's any cors errors or anything

@slmnio slmnio closed this as completed Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
section: server Relates to server or node scripts section: website Relates to website pages
Projects
None yet
Development

No branches or pull requests

1 participant