guile-1.8.8-cve-2016-8605.patch

commit 245608911698adb3472803856019bdd5670b6614
Author: Ludovic Courtès <ludo@gnu.org>
Date:   Tue Oct 11 10:14:26 2016 +0200

    Remove 'umask' calls from 'mkdir'.
    
    Fixes <http://bugs.gnu.org/24659>.
    
    * libguile/filesys.c (SCM_DEFINE): Remove calls to 'umask' when MODE is
    unbound; instead, use 0777 as the mode.  Update docstring to clarify
    this.
    * doc/ref/posix.texi (File System): Adjust accordingly.
    * NEWS: Mention it.

diff --git a/libguile/filesys.c b/libguile/filesys.c
index e6e1db5..e6e37b0 100644
--- a/libguile/filesys.c
+++ b/libguile/filesys.c
@@ -1255,26 +1255,21 @@ SCM_DEFINE (scm_getcwd, "getcwd", 0, 0, 0,
 SCM_DEFINE (scm_mkdir, "mkdir", 1, 1, 0,
             (SCM path, SCM mode),
 	    "Create a new directory named by @var{path}.  If @var{mode} is omitted\n"
-	    "then the permissions of the directory file are set using the current\n"
-	    "umask.  Otherwise they are set to the decimal value specified with\n"
-	    "@var{mode}.  The return value is unspecified.")
+	    "then the permissions of the directory are set to @code{#o777}\n"
+	    "masked with the current umask (@pxref{Processes, @code{umask}}).\n"
+	    "Otherwise they are set to the value specified with @var{mode}.\n"
+	    "The return value is unspecified.")
 #define FUNC_NAME s_scm_mkdir
 {
   int rv;
-  mode_t mask;
+  mode_t c_mode;
 
-  if (SCM_UNBNDP (mode))
-    {
-      mask = umask (0);
-      umask (mask);
-      STRING_SYSCALL (path, c_path, rv = mkdir (c_path, 0777 ^ mask));
-    }
-  else
-    {
-      STRING_SYSCALL (path, c_path, rv = mkdir (c_path, scm_to_uint (mode)));
-    }
+  c_mode = SCM_UNBNDP (mode) ? 0777 : scm_to_uint (mode);
+
+  STRING_SYSCALL (path, c_path, rv = mkdir (c_path, c_mode));
   if (rv != 0)
     SCM_SYSERROR;
+
   return SCM_UNSPECIFIED;
 }
 #undef FUNC_NAME