Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.AspNetCore.Authentication is deprecated #942

Open
assi010 opened this issue Nov 25, 2024 · 2 comments · May be fixed by #945
Open

Microsoft.AspNetCore.Authentication is deprecated #942

assi010 opened this issue Nov 25, 2024 · 2 comments · May be fixed by #945

Comments

@assi010
Copy link

assi010 commented Nov 25, 2024

The package Microsoft.AspNetCore.Authentication version 2.2.0 has been released in 2018 and has deprecated for a long time. Referencing this nuget package results in multiple vulnerabilities being included through its dependencies such as GHSA-ghhp-997w-qr28.

In the Microsoft docs #1 and #2 , it is explained that AspNetCore packages are no longer published on nuget since dotnet 2.2 and should be replaced with a FrameworkReference when used in class libraries. However, in my own testing locally it seems like removing the nuget reference altogether does not break the build or the tests.

Please consider either removing the reference or changing the current reference from a PackageReference to a FrameworkReference.

Thanks!

@buehler
Copy link
Collaborator

buehler commented Dec 2, 2024

Thank you for the new issue!

I would much appreciate a PR/MR for this!
Currently, I'm on a very tight schedule and do not have a lot of time left to work on such projects.

@assi010
Copy link
Author

assi010 commented Dec 2, 2024

No problem! I have created the PR, just let me know if there is anything else I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants