Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Content-Length where appropiate in server responses #1146

Closed
david-perez opened this issue Feb 2, 2022 · 2 comments · Fixed by #1423
Closed

Set Content-Length where appropiate in server responses #1146

david-perez opened this issue Feb 2, 2022 · 2 comments · Fixed by #1423
Labels
good first issue Good for newcomers server Rust server SDK

Comments

@david-perez
Copy link
Contributor

Server responses are not setting the Content-Length header where appropiate.
@david-perez david-perez added the server Rust server SDK label Feb 2, 2022
@david-perez david-perez mentioned this issue Feb 2, 2022
Merged
@david-perez
Copy link
Contributor Author

This will be easier to do after the refactoring introduced in #1158.

@david-perez
Copy link
Contributor Author

It's unclear whether Content-Length needs to be set if a streaming output has a size not known in advance smithy-lang/smithy#1086.

@david-perez david-perez added the good first issue Good for newcomers label May 27, 2022
@hlbarber hlbarber mentioned this issue May 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers server Rust server SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set Content-Length header in server responses smithy-lang/smithy-rs
1 participant
@david-perez