Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smithy logo is cut off in new docs website in Firefox #1351

Closed
david-perez opened this issue Aug 17, 2022 · 4 comments · Fixed by #2478
Closed

Smithy logo is cut off in new docs website in Firefox #1351

david-perez opened this issue Aug 17, 2022 · 4 comments · Fixed by #2478
Labels
documentation This is a problem with documentation.

Comments

@david-perez
Copy link
Contributor

Both the v1 and v2 doc websites exhibit this behavior. I can't reproduce in Chromium.

image

@milesziemer
Copy link
Contributor

Thanks for reporting. I'm unable to reproduce this behavior, I'll need some more information about your environment. What is your operating system, and what is the Firefox version?

@milesziemer milesziemer added the documentation This is a problem with documentation. label Aug 17, 2022
@david-perez
Copy link
Contributor Author

Firefox 103.0 on Ubuntu 18.04.6.

@david-perez
Copy link
Contributor Author

I can reproduce with Firefox 104.0.1 on Ubuntu 22.04 too.

@jffrenc
Copy link

jffrenc commented Feb 14, 2023

Reproducible with FF on 20.04.

The preferred font Open Sans is not installed (seemingly by default), so Firefox ends up choosing DejaVu Sans as sans-serif for the SVG and both the overall width and weight of the text is affected. Chrome, for me, chooses Liberation Sans for sans-serif, which just so happens to fit within the viewbox.

Installed fonts-open-sans and the logo then appeared similar to Chrome. Removed it, and the logo was again distorted and cut off.

For something as visually-critical as a logo seems like we wouldn't want to rely on users having the right fonts. We could keep using an SVG version of this logo if we convert the text to a path instead. The logo looks like it could also use some cleanup regarding the hammer - it's a raster image, but is a simple shape and looks straightforward to turn into a path. Or just go full raster with the logo for browser usage (doesn't seem to exist in the repo yet). 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants