Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing lodash dependency #143

Merged
merged 1 commit into from
Sep 28, 2018

Conversation

brendonbribeiro
Copy link
Contributor

Summary

My first PR to the project

Hey, started using this repository today. Jest and Puppeteer are for me, a really good replacement to selenium...

Here is what I did:

  • Removed lodash
  • Add merge-deep
  • Run yarn && yarn build && yarn test and looks like everything is okay

closes #139

@gregberge gregberge merged commit 0cf7109 into argos-ci:master Sep 28, 2018
@gregberge
Copy link
Member

Hi @brendonbarreto, perfect, thank you!

@brendonbribeiro brendonbribeiro deleted the replacing-lodash branch September 28, 2018 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use merge-deep instead of lodash
2 participants