Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose servers #166

Merged
merged 2 commits into from
Dec 10, 2018
Merged

feat: expose servers #166

merged 2 commits into from
Dec 10, 2018

Conversation

xiaoyuhen
Copy link
Contributor

Summary

  • expose a method getServers
  • setupJestServer should not be exported

see #135

gregberge
gregberge requested changes Dec 10, 2018
View reviewed changes
Copy link
Member

@gregberge gregberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! Can you please fix the async function?

packages/jest-dev-server/src/global.js Outdated Show resolved Hide resolved
@xiaoyuhen
Copy link
Contributor Author

hi, @neoziro

Thanks for your code review, I have fixed this.

@gregberge gregberge merged commit be650a3 into argos-ci:master Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregberge gregberge gregberge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaoyuhen @gregberge