Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slowmo causes test to fail #36

Closed
melissachang opened this issue Apr 13, 2018 · 3 comments
Closed

slowmo causes test to fail #36

melissachang opened this issue Apr 13, 2018 · 3 comments

Comments

@melissachang
Copy link
Contributor

melissachang commented Apr 13, 2018 •
edited
Loading

Repro
@melissachang melissachang changed the title slowmo causes test to fails slowmo causes test to fail Apr 13, 2018
@gregberge
Copy link
Member

Actually expect-puppeteer have a default timeout of 500ms. This is the cause of the bug. I think I will make it configurable and automatically delay it with slowMo option.

@gregberge gregberge added the bug label Apr 16, 2018
@melissachang
Copy link
Contributor Author

I don't care where slowMo default is defined (expect-puppeteer, jest-puppeteer, etc), but can the default be the same as in puppeeter, which I think is 0?

@gregberge
Copy link
Member

slowMo default is 0, but when you changed it tests have to wait more in order to pass. So this is actually a bug.

gregberge added a commit that referenced this issue Apr 24, 2018
@gregberge
feat: adjust default timeout with slowMo
6871ec8 
Closes #36
@gregberge gregberge mentioned this issue Apr 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gregberge @melissachang