Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Catch exceptions on browser close or disconnect during teardown #453

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

muka
Copy link
Contributor

@muka muka commented Nov 22, 2021

Summary

Address #388

Test plan

Expect the test to close properly without Navigation failed because browser has disconnected! exceptions

@muka muka changed the title Update global.js Catch exceptions on browser close or disconnect during teardown (global.js) Nov 22, 2021
@UziTech UziTech changed the title Catch exceptions on browser close or disconnect during teardown (global.js) fix: Catch exceptions on browser close or disconnect during teardown Nov 23, 2021
@UziTech UziTech merged commit adafcc2 into argos-ci:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail with UnhandledPromiseRejectionWarning if they connect to imgur.com
2 participants