fix(expect-puppeteer): return proper error stack traces from matchers #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UziTech
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, errors thrown from matchers have a corrupt stack trace, making it impossible for the developer to tell which line of the test caused the error.
e.g.:
With the fix, the errors look good, with all the stack trace info:
This bug is caused by calling
Error.captureStackTracewith the wrong 2nd parameter. Unfortunately, sincecreateMatcheris not part of the stack trace, the entire stack trace is removed.createMatcherwill never be part of the stack trace, the function that should be removed from the trace is the inner function,throwingMatcher.