-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding server port ask for root password #96
Comments
Hi, |
I think it is a problem in your server. You should try to run "npm start" without Jest Puppeteer and see what's going on. The requirement of a root password can be multiple things: a usage of a restricted port, the execution rights of the process... This issue is not relative to Jest Puppeteer but I let it opened if someone want to help. |
@neoziro I wouldn't be so sure about "This issue is not relative to Jest Puppeteer". I use lots of different servers, using the same terminal, user, port, interface, groups, interfaces both for puppeteer and also other servers on top of jest and never had this problem. Did you tried to reproduce the issue in arch linux at least ? is as easy as providing the configuration I just did in my first comment. I had reproduce it using arch linux and manjaro linux (archlinux - based distribution). Both are very popular linux distros BTW. Will try to see if the same happens on debian or other distros but unfortunately don't have much time to invest on this. Thanks. |
Thank you for your answer @cancerberoSgx, @neoziro ;-) |
I have the same issue. This is because This is really unfortunate, this project seemed nice but I really can't enter my root password every time I need to run tests. I guess setting |
@BenoitZugmeyer good catch thanks, so it is actually a bug. |
I have the same. config.usedPortAction = 'ignore' this doesnt work for me. So how can i fix that? |
Any news on this ? Why is it jest-puppeteer scanning my processes ? IMO, As the user I expect to be responsible of providing the port number, if it's busy is my problem. This tool should just open the server on that port and that's it. Thanks. |
I workaround (hack) would be to put |
documents change argos-ci@cceb0bd and argos-ci#96
I don't understand why this was closed. I would expect jest-puppeteers |
I think it is not possible to test if port is used without sudo. In fact it is because I had never experienced this issue on Mac. Anyway I can't do anything for it, you should investigate in |
I can't see how that is necessary, unless you either want to bind to ports numbered less than 1024 or want to get the process id of the process listening to the port. Here is a tiny POC:
(I have something on that port.) |
If |
Yes you are right, could you submit a fix? |
Ok. I'm on it :-) |
@neoziro - I suppose the fix goes into jest-dev-server, not jest-puppeteer. |
Of course 😉, but it is in the same repo. |
…uper user login, see argos-ci#96.
I haven't had time to test it yet, but I'd like to know if this is the right direction, I'm taking. |
This works in my system (arch linux, node 10, latest puppeteteer, jest, etc)
But if I add the port number, (high number like 3001 and not busy) then the test interrupts and the terminal ask for my root password like sudo. Is that normal? I'm not entering my root password for running a test, at all and I know in my system my user has permissions to open / close it...
I'm able to run the command manually OK. I tried with headless: false, --disable-setuid-sandbox and
--usedPortAction: 'error' but with no luck,
DO you think this is a problem with sandbox ? I wanted to report this since recent security incidents in npmjs.org - sore is nothing but just in case.
Will try to reproduce the issue in jest-dev-server. Any tip / help is appreciated. Thanks - good work, keep it up
The text was updated successfully, but these errors were encountered: