Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isGuid() should return FALSE for null, undefined, and "" #23

Open
kwils1997 opened this issue Oct 5, 2022 · 1 comment
Open

isGuid() should return FALSE for null, undefined, and "" #23

kwils1997 opened this issue Oct 5, 2022 · 1 comment

Comments

@kwils1997
Copy link

Right now "isGuid()" throws an exception if you pass it null or undefined... and this function (which is defined as returning a boolean) returns a blank string if you pass it a blank string (which makes no sense).

"isGuid()" should return FALSE for null, undefined, or blank string.
@kwils1997
Copy link
Author

I've proposed a simple fix for this problem in this change request:

master...kwils1997:guid-typescript:patch-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kwils1997