Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No License file or version tags #7

Open
PLPSDev opened this issue Jan 23, 2019 · 4 comments
Open

No License file or version tags #7

PLPSDev opened this issue Jan 23, 2019 · 4 comments

Comments

@PLPSDev
Copy link

PLPSDev commented Jan 23, 2019

I love this library but am having issues getting it approved for use in a production environment.

At https://www.npmjs.com/package/guid-typescript you indicate that the license is ISC but there is no License file within the repository. Would it be possible to add one?

Also, would it be possible to tag the commits that form each new version? There are 10 versions in npm but it is awkward to find historically what the last commit was for each version. Basically the managers want snapshots of the repository with the License file at a particular point in time so they can approve those.

Many thanks

@avmaisak
Copy link

@gekkedev
Copy link
Contributor

@avmaisak No, it's not. You changed the license 😞

@avmaisak
Copy link

@gekkedev fixed

@pepijnmm
Copy link

pepijnmm commented Jan 13, 2023

just wanted to give a small heads-up to anyone who is also curious about the license of this project.
In the package.json it states that the license is "ISC". So the license file @avmaisak added is the correct license.
Although I agree with @gekkedev that adding a license file yourself if you aren't the copyright holder isn't the right way nor would it be legal if it wasn't already the license of this project to begin with.
I myself use uuid as it has the features I need and is kept up-to-date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants