Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some users have deleted their location #13251

Closed
2 tasks done
UserGoodtm opened this issue Jul 4, 2023 · 5 comments
Closed
2 tasks done

Some users have deleted their location #13251

UserGoodtm opened this issue Jul 4, 2023 · 5 comments
Assignees
Labels
ldap ❓ not sure if bug This issue has not been confirmed as a bug yet

Comments

@UserGoodtm
Copy link

Debug mode

Describe the bug

The other day I updated to the latest version 6.1.1 from 6.1.0. And today I found that some users have deleted the location. I found out experimentally that this was due to synchronization with LDAP (AD). My setup doesn't use the location field for synchronization, so it shouldn't have affected in any way, but it did.

Reproduction steps

  1. Updated to the latest version 6.1.1
  2. I didn't make any changes in the LDAP settings
  3. Synchronized users with AD (LDAP)
  4. Many users have deleted the location
    ...

Expected behavior

Changes should only occur with direct instructions to do so. If there are empty fields in the parameter settings, without instructions, then changes to these parameters should not occur

Screenshots

No response

Snipe-IT Version

v6.1.1 build 10847

Operating System

CentOS

Web Server

Apache

PHP Version

7.4.29

Operating System

Windows

Browser

All

Version

Last

Device

No response

Operating System

No response

Browser

No response

Version

No response

Error messages

No response

Additional context

Is this a fresh install or an upgrade? - upgrade

@snipe
Copy link
Owner

snipe commented Jul 5, 2023

Do you have any value in the LDAP Location field in your LDAP settings?

Screenshot 2023-07-05 at 4 07 10 PM

@snipe snipe added the ldap label Jul 5, 2023
@xinput
Copy link

xinput commented Jul 6, 2023

We have the same issue on our instance after updating to 6.1.1
Also an update to 6.1.2 did not fixed the issue.

Another UAT instance running on 6.1.0 does not have this issue.

it seems not all users are affected, it's like around 60-70% of users where location has been deleted. Also checked the database, their Location ID is set to NULL.

@snipe LDAP location field in LDAP Setting is empty also checked in settings table in DB and verified the value of ldap_location is NULL

@snipe snipe added the ❓ not sure if bug This issue has not been confirmed as a bug yet label Jul 6, 2023
@UserGoodtm
Copy link
Author

Do you have any value in the LDAP Location field in your LDAP settings?

Screenshot 2023-07-05 at 4 07 10 PM

No. There is no data in the input field. The field is empty. By meaning, if the field is empty, then no actions (synchronization) should be performed

@maur27-it
Copy link

We have the same issue. I updated to v6.1.1 and after LDAP sync all locations for active users are deleted. So in our case this issue affects all active users. I also tried setting the same location name in AD and in Snipe-IT, but it doesn't work. In previous version v6.0.14 LDAP sync didn't delete the locations and everything works correctly.

The "LDAP Location" field is empty. And I didn't find any other property for LDAP location sync.

@snipe
Copy link
Owner

snipe commented Jul 20, 2023

This was fixed in #13322

@snipe snipe closed this as completed Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ldap ❓ not sure if bug This issue has not been confirmed as a bug yet
Projects
None yet
Development

No branches or pull requests

6 participants