Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature pad seems morphed on very small screens #15530

Closed
2 tasks done
Akhun-Delar opened this issue Sep 19, 2024 · 11 comments
Closed
2 tasks done

Signature pad seems morphed on very small screens #15530

Akhun-Delar opened this issue Sep 19, 2024 · 11 comments
Assignees

Comments

@Akhun-Delar
Copy link

Akhun-Delar commented Sep 19, 2024

Debug mode

Describe the bug

When signing on a tablet in horizontal mode (or any screen like this), the signature pad seems "morphed". The more I move the pen to the right, the more it differs to this direction. In the left, pen and the line are correct.

Reproduction steps

  1. Checkout an asset with a necessary signature
  2. Start the acceptance process on a smaller screen like a tablet in horizontal mode (also happens if you lower size of your browser window)
  3. Signature pad bugging

Expected behavior

Signature pad working as expected

Screenshots

No response

Snipe-IT Version

v7.0.11 & v7.0.12 as well

Operating System

Ubuntu 24.04

Web Server

Apache

PHP Version

8.1.2

Operating System

Windows 11

Browser

Google Chrome

Version

122.0.6261.129

Device

No response

Operating System

No response

Browser

No response

Version

No response

Error messages

No response

Additional context

No response

Repository owner deleted a comment Sep 19, 2024
@snipe
Copy link
Owner

snipe commented Sep 19, 2024

Can you provide a screenshot or video? I'm not sure exactly what you mean.

@Akhun-Delar
Copy link
Author

Akhun-Delar commented Sep 19, 2024

Of course! This is in Chrome on my normal PC, window resized. Doesn't happen when you open the page on full wide screen, but only if you have the resized window and then load the page (or F5)

The bug seems to start at a screensize where the left menu bar is hidden

signature.mp4

@snipe snipe added the ✋ bug Confirmed bug label Sep 20, 2024
@snipe
Copy link
Owner

snipe commented Sep 20, 2024

Hm. Is what I'm seeing different than what you're expecting?

Screen.Recording.2024-09-20.at.5.15.59.PM.mov

@Akhun-Delar
Copy link
Author

Basically yeah. If you watch closely, the drawn line also differs in your video. It's not on the cursor anymore when you go right.

@snipe
Copy link
Owner

snipe commented Sep 20, 2024

I'm not sure exactly whether or not we can address that as it's a third party library, but I can certainly have @Godmartinz take a peek on Monday.

@Akhun-Delar
Copy link
Author

No worries, our temporary solution is having tablets in widescreen mode lol

@snipe
Copy link
Owner

snipe commented Sep 20, 2024

I mean, I use touchscreen signatures all the time here to sign for packages, and I'd wonder if any living person has ever successfully backed up that signature in a legal case, since it never looks like my actual signature. But this does seem to be a behavioral change.

I know we made a few small tweaks on that page recently, so it might be messing with the CSS. It's also interesting that it seems consistently inconsistent.

My early tests show that it gets further away from the pointer the further right you move on the sign pad.

Screen.Recording.2024-09-20.at.5.59.20.PM.mov

@snipe
Copy link
Owner

snipe commented Sep 20, 2024

Quick question (if your use-case supports this) - does this only happen on asset acceptance+sign, or on accessory, etc acceptance+sign as well?

@snipe snipe changed the title Signature pad seems morphed Signature pad seems morphed on very small screens Sep 21, 2024
@Akhun-Delar
Copy link
Author

Sorry for the delay, I tested now with Accessories - same thing happening :(

@snipe
Copy link
Owner

snipe commented Oct 2, 2024

@Godmartinz do we have any updates on this one?

@marcusmoore marcusmoore self-assigned this Oct 2, 2024
@marcusmoore
Copy link
Collaborator

I took this one over. No update besides being able to reproduce locally and jotted a few notes down about some config changes to try from the upstream library we're using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants