Resolved Potential Issue when Deleting Personal Access Tokens

[spencerrlongg]

Description

Fixes an issue in which a user could either double click the delete button and throw an error, or throw an error by editing their HTML and providing an un-deletable token ID

Chaining ? also means an error won't throw if the user were to manually edit the ID to something invalid.

Should probably start using wire:loading.attr="disabled" by default on Livewire buttons, will go through them next week.

Fixes SC-26090

Had to enable "Slow 3G" in Chrome to test this locally.

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

[what-the-diff]

PR Summary

• Improvement in Deletion Process
  Earlier deletion process in PersonalAccessTokens.php was prone to errors when attempting to delete an already non-existing token. This PR significantly improves reliability by introducing a null-safe operator before deletion function call. This change essentially makes the deletion process error-free even when faced with null values.

• Loading State UI Enhancement
  Modifications have been made to the delete button in personal-access-tokens.blade.php. This change shows visual feedback to user on button when the deletion process is ongoing. The delete button now gets disabled during this process, preventing the triggering of redundant and possibly error-prone delete operations. This greatly improves user experience during interactions.

[snipe]

Nice, thank you!