Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed shortcuts to be optional now #15242

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Aug 7, 2024

Description

This adds a setting to enable/disable shortcuts.
image

Fixes #[sc-26405]

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

Copy link

what-the-diff bot commented Aug 7, 2024

PR Summary

  • Addition of 'shortcuts_enabled' field to 'settings' table
    The developer added a field called 'shortcuts_enabled' to the 'settings' database table, including the accompanying migration file, which helps facilitate the change in the database structure.

  • Updating language file
    The 'shortcuts_enabled' field has been added to the 'general.php' language file. This suggests the team is preparing for localization or multilingual support for shortcut related features.

  • Adding shortcut accessibility in various interface elements
    The PR also makes several user interface improvements. Certain buttons and links in various sections of the application ('accessories', 'components', 'consumables', 'hardware') now have an 'accesskey' attribute. This means that if the shortcut feature is enabled in the settings, users can use specific keyboard shortcuts to interact with these elements, effectively speeding up user interactions.

  • Inclusion of 'shortcuts_enabled' in settings form
    The settings form has been modified to include the 'shortcuts_enabled' field, allowing users to easily enable or disable keyboard shortcuts in the system.

@Godmartinz
Copy link
Collaborator Author

Done 👍

@Godmartinz Godmartinz requested a review from snipe August 7, 2024 17:54
@snipe
Copy link
Owner

snipe commented Aug 7, 2024

Nice work!

@snipe snipe merged commit ef183f2 into snipe:develop Aug 7, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants