Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added employee number to asset view #15431

Merged
merged 1 commit into from
Aug 31, 2024
Merged

Conversation

snipe
Copy link
Owner

@snipe snipe commented Aug 31, 2024

This went a little out of scope, but I think the changes are good. As we continue to build out the visual lexicon, I think these changes will matter.

The initial change was just to add the employee ID to the asset "checked out to" section.

In the future, I might make this a popout menu or user card to save space, but I'm okay with the solution I have here for now.

Note I did not include the glyph if it's checked out to user, since the gravatar() method already handles that.

Screenshot 2024-08-31 at 1 39 28 PM Screenshot 2024-08-31 at 1 43 27 PM

Copy link

what-the-diff bot commented Aug 31, 2024

PR Summary

  • Extension of Icon Functionality
    The file IconHelper.php has been updated to incorporate new icon categories like 'asset', 'accessory', 'component', 'consumable', and 'license'. This expansion allows for better visual differentiation and improved user interaction.

  • Additional User Information Display
    Updates on hardware/view.blade.php file enhance user data display by introducing an additional item listing where it shows the checked-out user's employee number. This aids in efficient user identification.

@snipe snipe merged commit f8bbb7a into develop Aug 31, 2024
8 of 9 checks passed
@snipe snipe deleted the add_employee_num_to_asset_overview branch August 31, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant