From 2d9a5b9fad60488efebb811afd47341e87025044 Mon Sep 17 00:00:00 2001 From: Marcus Moore Date: Mon, 25 Nov 2024 14:43:27 -0800 Subject: [PATCH 01/28] Add textarea component --- resources/views/blade/input/textarea.blade.php | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 resources/views/blade/input/textarea.blade.php diff --git a/resources/views/blade/input/textarea.blade.php b/resources/views/blade/input/textarea.blade.php new file mode 100644 index 000000000000..ba203271b137 --- /dev/null +++ b/resources/views/blade/input/textarea.blade.php @@ -0,0 +1,16 @@ +@props([ + 'name', + // use name if id is not provided + 'id' => $id ?? $name, + 'value' => '', + 'cols' => 50, + 'rows' => 10, +]) + + From 6ba467b3f15e92fbfddcc8c3bb7ee5bc0432ad67 Mon Sep 17 00:00:00 2001 From: Marcus Moore Date: Mon, 25 Nov 2024 14:43:49 -0800 Subject: [PATCH 02/28] Replace branding and eula textareas with new component --- resources/views/settings/branding.blade.php | 8 ++++---- resources/views/settings/general.blade.php | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/resources/views/settings/branding.blade.php b/resources/views/settings/branding.blade.php index c586917ef534..19841ec416e3 100644 --- a/resources/views/settings/branding.blade.php +++ b/resources/views/settings/branding.blade.php @@ -233,11 +233,11 @@
@if (config('app.lock_passwords')===true) - {{ Form::textarea('custom_css', old('custom_css', $setting->custom_css), array('class' => 'form-control','placeholder' => 'Add your custom CSS','disabled'=>'disabled', 'aria-label'=>'custom_css')) }} + {!! $errors->first('custom_css', '') !!}

{{ trans('general.feature_disabled') }}

@else - {{ Form::textarea('custom_css', old('custom_css', $setting->custom_css), array('class' => 'form-control','placeholder' => 'Add your custom CSS', 'aria-label'=>'custom_css')) }} + {!! $errors->first('custom_css', '') !!} @endif

{!! trans('admin/settings/general.custom_css_help') !!}

@@ -289,10 +289,10 @@
@if (config('app.lock_passwords')===true) - {{ Form::textarea('footer_text', old('footer_text', $setting->footer_text), array('class' => 'form-control', 'rows' => '4', 'placeholder' => 'Optional footer text','disabled'=>'disabled')) }} +

{{ trans('general.feature_disabled') }}

@else - {{ Form::textarea('footer_text', old('footer_text', $setting->footer_text), array('class' => 'form-control','rows' => '4','placeholder' => 'Optional footer text')) }} + @endif

{!! trans('admin/settings/general.footer_text_help') !!}

{!! $errors->first('footer_text', '') !!} diff --git a/resources/views/settings/general.blade.php b/resources/views/settings/general.blade.php index 17c0a8ec81db..536f4cc4b3e6 100644 --- a/resources/views/settings/general.blade.php +++ b/resources/views/settings/general.blade.php @@ -208,7 +208,7 @@ {{ Form::label('default_eula_text', trans('admin/settings/general.default_eula_text')) }}
- {{ Form::textarea('default_eula_text', old('default_eula_text', $setting->default_eula_text), array('class' => 'form-control','placeholder' => 'Add your default EULA text')) }} + {!! $errors->first('default_eula_text', '') !!}

{{ trans('admin/settings/general.default_eula_help_text') }}

{!! trans('admin/settings/general.eula_markdown') !!}

From 80205275b3a3e5f1fa8bbae48ed30904c364590b Mon Sep 17 00:00:00 2001 From: Marcus Moore Date: Mon, 25 Nov 2024 15:09:37 -0800 Subject: [PATCH 03/28] Convert a couple more templates --- resources/views/custom_fields/fields/edit.blade.php | 2 +- resources/views/livewire/category-edit-form.blade.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/views/custom_fields/fields/edit.blade.php b/resources/views/custom_fields/fields/edit.blade.php index 12c3a3fb735e..97937ee48ddd 100644 --- a/resources/views/custom_fields/fields/edit.blade.php +++ b/resources/views/custom_fields/fields/edit.blade.php @@ -70,7 +70,7 @@ {{ trans('admin/custom_fields/general.field_values') }}
- {!! Form::textarea('field_values', old('name', $field->field_values), ['style' => 'width: 100%', 'rows' => 4, 'class' => 'form-control', 'aria-label'=>'field_values']) !!} + {!! $errors->first('field_values', '') !!}

{{ trans('admin/custom_fields/general.field_values_help') }}

diff --git a/resources/views/livewire/category-edit-form.blade.php b/resources/views/livewire/category-edit-form.blade.php index cb80eb45d3d8..643a14049949 100644 --- a/resources/views/livewire/category-edit-form.blade.php +++ b/resources/views/livewire/category-edit-form.blade.php @@ -3,7 +3,7 @@
- {{ Form::textarea('eula_text', null, ['wire:model.live' => 'eulaText', 'class' => 'form-control', 'aria-label'=>'eula_text', 'disabled' => $this->eulaTextDisabled]) }} +

{!! trans('admin/categories/general.eula_text_help') !!}

{!! trans('admin/settings/general.eula_markdown') !!}

{!! $errors->first('eula_text', '') !!} From c35f70b4c7201a11f2bd23a83b9c37bfdaef4305 Mon Sep 17 00:00:00 2001 From: Marcus Moore Date: Mon, 25 Nov 2024 15:27:57 -0800 Subject: [PATCH 04/28] Convert textarea in ldap settings --- resources/views/settings/ldap.blade.php | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/resources/views/settings/ldap.blade.php b/resources/views/settings/ldap.blade.php index 5b483f48a2ea..b08e75d57c91 100644 --- a/resources/views/settings/ldap.blade.php +++ b/resources/views/settings/ldap.blade.php @@ -174,7 +174,12 @@ {{ Form::label('ldap_client_tls_key', trans('admin/settings/general.ldap_client_tls_key')) }}
- {{ Form::textarea('ldap_client_tls_key', old('ldap_client_tls_key', $setting->ldap_client_tls_key), ['class' => 'form-control','placeholder' => trans('general.example') .'-----BEGIN RSA PRIVATE KEY-----'."\r\n1234567890\r\n-----END RSA PRIVATE KEY-----"]) }} + + @error('ldap_client_tls_key') @@ -197,7 +202,11 @@ {{ Form::label('ldap_client_tls_cert', trans('admin/settings/general.ldap_client_tls_cert')) }}
- {{ Form::textarea('ldap_client_tls_cert', old('ldap_client_tls_cert', $setting->ldap_client_tls_cert), ['class' => 'form-control','placeholder' => trans('general.example') .'-----BEGIN CERTIFICATE-----'."\r\n1234567890\r\n-----END CERTIFICATE-----"]) }} +

{{ trans('admin/settings/general.ldap_client_tls_cert_help') }}

@error('ldap_client_tls_cert') From 6af8412f63df4507c936d4830feea242defe81f9 Mon Sep 17 00:00:00 2001 From: Marcus Moore Date: Mon, 25 Nov 2024 16:46:28 -0800 Subject: [PATCH 05/28] Convert textarea in saml settings --- resources/views/settings/saml.blade.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/resources/views/settings/saml.blade.php b/resources/views/settings/saml.blade.php index 9349023fc814..3beb639c1536 100644 --- a/resources/views/settings/saml.blade.php +++ b/resources/views/settings/saml.blade.php @@ -83,7 +83,7 @@ @if (!empty($setting->saml_sp_x509cert)) {{ Form::label('saml_sp_x509cert', trans('admin/settings/general.saml_sp_x509cert')) }} - {{ Form::textarea('saml_sp_x509cert', $setting->saml_sp_x509cert, ['class' => 'form-control', 'wrap' => 'off', 'readonly']) }} +
@endif @@ -106,7 +106,7 @@ {{ Form::label('saml_idp_metadata', trans('admin/settings/general.saml_idp_metadata')) }}
- {{ Form::textarea('saml_idp_metadata', old('saml_idp_metadata', $setting->saml_idp_metadata), ['class' => 'form-control','placeholder' => 'https://example.com/idp/metadata', 'wrap' => 'off', $setting->demoMode]) }} + {!! $errors->first('saml_idp_metadata', '') !!}
- {{ Form::textarea('saml_custom_settings', old('saml_custom_settings', $setting->saml_custom_settings), ['class' => 'form-control','placeholder' => 'example.option=false sp_x509cert=file:///... sp_private_key=file:///', 'wrap' => 'off', $setting->demoMode]) }} +

{{ trans('admin/settings/general.saml_custom_settings_help') }}

{!! $errors->first('saml_custom_settings', '') !!}
From 07b5544243d79cef13c18b503f3673428257c37e Mon Sep 17 00:00:00 2001 From: Marcus Moore Date: Mon, 25 Nov 2024 17:21:20 -0800 Subject: [PATCH 06/28] Convert textarea in upload modal --- resources/views/modals/upload-file.blade.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/views/modals/upload-file.blade.php b/resources/views/modals/upload-file.blade.php index c5816bf175f4..184110fb0f80 100644 --- a/resources/views/modals/upload-file.blade.php +++ b/resources/views/modals/upload-file.blade.php @@ -31,7 +31,7 @@
- {{ Form::textarea('notes', old('notes', old('notes')), ['class' => 'form-control','placeholder' => 'Notes (Optional)', 'rows'=>3, 'aria-label' => 'file']) }} +
From b6f8ac42c423c2feb5660b33851ed136c7fe41be Mon Sep 17 00:00:00 2001 From: Marcus Moore Date: Tue, 26 Nov 2024 14:30:33 -0800 Subject: [PATCH 07/28] Convert some selects --- resources/views/blade/input/select.blade.php | 16 ++++++++++++++++ resources/views/categories/edit.blade.php | 9 ++++++++- .../views/custom_fields/fieldsets/view.blade.php | 8 ++++++-- resources/views/hardware/checkin.blade.php | 10 ++++++++-- resources/views/statuslabels/edit.blade.php | 8 +++++++- 5 files changed, 45 insertions(+), 6 deletions(-) create mode 100644 resources/views/blade/input/select.blade.php diff --git a/resources/views/blade/input/select.blade.php b/resources/views/blade/input/select.blade.php new file mode 100644 index 000000000000..7bcb11fd99f2 --- /dev/null +++ b/resources/views/blade/input/select.blade.php @@ -0,0 +1,16 @@ +@props([ + 'items', + 'selected' => null, + 'includeEmpty' => false, +]) + + diff --git a/resources/views/categories/edit.blade.php b/resources/views/categories/edit.blade.php index 1ef3b7aa6a8d..ba772f25bb8e 100755 --- a/resources/views/categories/edit.blade.php +++ b/resources/views/categories/edit.blade.php @@ -15,7 +15,14 @@
- {{ Form::select('category_type', $category_types , old('category_type', $item->category_type), array('class'=>'select2', 'style'=>'min-width:350px', 'aria-label'=>'category_type', ($item->category_type!='') || ($item->itemCount() > 0) ? 'disabled' : '')) }} + {!! $errors->first('category_type', '') !!}
diff --git a/resources/views/custom_fields/fieldsets/view.blade.php b/resources/views/custom_fields/fieldsets/view.blade.php index b73ae708c669..0c608a8303a9 100644 --- a/resources/views/custom_fields/fieldsets/view.blade.php +++ b/resources/views/custom_fields/fieldsets/view.blade.php @@ -98,8 +98,12 @@ - {{ Form::select("field_id",$custom_fields_list,"",['aria-label'=>'field_id', 'class'=>'select2', 'style' => 'min-width:400px;']) }} - +
@@ -142,4 +148,4 @@
-@stop \ No newline at end of file +@stop diff --git a/resources/views/statuslabels/edit.blade.php b/resources/views/statuslabels/edit.blade.php index af69f35de81e..4843b5046c0c 100755 --- a/resources/views/statuslabels/edit.blade.php +++ b/resources/views/statuslabels/edit.blade.php @@ -27,7 +27,13 @@ {{ trans('admin/statuslabels/table.status_type') }}
- {{ Form::select('statuslabel_types', $statuslabel_types, $item->getStatuslabelType(), array('class'=>'select2', 'style'=>'width: 100%; min-width:400px', 'aria-label'=>'statuslabel_types')) }} + {!! $errors->first('statuslabel_types', '') !!}
From 447bb40a472671bd2cfe6001d857ec0375b92531 Mon Sep 17 00:00:00 2001 From: Marcus Moore Date: Tue, 26 Nov 2024 14:47:35 -0800 Subject: [PATCH 08/28] Convert selects on branding settings page --- resources/views/settings/branding.blade.php | 47 ++++++++++++++++++--- 1 file changed, 42 insertions(+), 5 deletions(-) diff --git a/resources/views/settings/branding.blade.php b/resources/views/settings/branding.blade.php index 19841ec416e3..5bae1452b4f9 100644 --- a/resources/views/settings/branding.blade.php +++ b/resources/views/settings/branding.blade.php @@ -67,7 +67,14 @@ {{ Form::label('brand', trans('admin/settings/general.web_brand')) }}
- {!! Form::select('brand', array('1'=>'Text','2'=>'Logo','3'=>'Logo + Text'), old('brand', $setting->brand), array('class' => 'form-control select2', 'style'=>'width: 150px ;')) !!} + {!! $errors->first('brand', '') !!}
@@ -252,10 +259,25 @@
@if (config('app.lock_passwords')===true) - {!! Form::select('support_footer', array('on'=>'Enabled','off'=>'Disabled','admin'=>'Superadmin Only'), old('support_footer', $setting->support_footer), ['class' => 'form-control select2 disabled', 'style'=>'width: 150px ;', 'disabled' => 'disabled']) !!} +

{{ trans('general.feature_disabled') }}

@else - {!! Form::select('support_footer', array('on'=>'Enabled','off'=>'Disabled','admin'=>'Superadmin Only'), old('support_footer', $setting->support_footer), array('class' => 'form-control select2', 'style'=>'width: 150px ;')) !!} + @endif @@ -271,10 +293,25 @@
@if (config('app.lock_passwords')===true) - {!! Form::select('version_footer', array('on'=>'Enabled','off'=>'Disabled','admin'=>'Superadmin Only'), old('version_footer', $setting->version_footer), ['class' => 'form-control select2 disabled', 'style'=>'width: 150px ;', 'disabled' => 'disabled']) !!} +

{{ trans('general.feature_disabled') }}

@else - {!! Form::select('version_footer', array('on'=>'Enabled','off'=>'Disabled','admin'=>'Superadmin Only'), old('version_footer', $setting->version_footer), array('class' => 'form-control select2', 'style'=>'width: 150px ;')) !!} + @endif

{{ trans('admin/settings/general.version_footer_help') }}

From f80b2716f002e1dc3d00ed6efa9c1c53a349963c Mon Sep 17 00:00:00 2001 From: Marcus Moore Date: Tue, 26 Nov 2024 15:55:47 -0800 Subject: [PATCH 09/28] Convert selects on general settings page --- resources/views/settings/general.blade.php | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/resources/views/settings/general.blade.php b/resources/views/settings/general.blade.php index 536f4cc4b3e6..ef5f07909cce 100644 --- a/resources/views/settings/general.blade.php +++ b/resources/views/settings/general.blade.php @@ -342,9 +342,12 @@ trans('general.pie_chart_type')) }}
- {{ Form::select('dash_chart_type', array( - 'name' => 'Status Label Name', - 'type' => 'Status Label Type'), old('dash_chart_type', $setting->dash_chart_type), ['class' =>'select2', 'style' => 'width: 80%']) }} +
@@ -355,11 +358,13 @@ {{ Form::label('depreciation_method', trans('Depreciation method')) }}
- {{ Form::select('depreciation_method', array( - 'default' => 'Linear (default)', - 'half_1' => 'Half-year convention, always applied', - 'half_2' => 'Half-year convention, applied with condition', - ), old('username_format', $setting->depreciation_method), ['class' =>'select2', 'style' => 'width: 80%']) }} +
From 8ad3ec56eab76cef88416af9fd368608e3d307e8 Mon Sep 17 00:00:00 2001 From: Marcus Moore Date: Tue, 3 Dec 2024 14:10:07 -0800 Subject: [PATCH 10/28] Convert additional selects --- .../views/custom_fields/fields/edit.blade.php | 9 ++++++- resources/views/hardware/bulk.blade.php | 8 +++++- resources/views/hardware/checkout.blade.php | 8 +++++- resources/views/settings/labels.blade.php | 27 ++++++++++++++++--- 4 files changed, 46 insertions(+), 6 deletions(-) diff --git a/resources/views/custom_fields/fields/edit.blade.php b/resources/views/custom_fields/fields/edit.blade.php index 97937ee48ddd..558231b9d282 100644 --- a/resources/views/custom_fields/fields/edit.blade.php +++ b/resources/views/custom_fields/fields/edit.blade.php @@ -88,7 +88,14 @@ } @endphp
- {{ Form::select("format",Helper::predefined_formats(), ($field_format == '') ? $field->format : $field_format, array('class'=>'format select2 form-control', 'aria-label'=>'format', 'style' => 'width:100%;')) }} + {!! $errors->first('format', '') !!}
diff --git a/resources/views/hardware/bulk.blade.php b/resources/views/hardware/bulk.blade.php index cc44993af50a..05f5b517c0d6 100755 --- a/resources/views/hardware/bulk.blade.php +++ b/resources/views/hardware/bulk.blade.php @@ -125,7 +125,13 @@ {{ trans('admin/hardware/form.status') }}
- {{ Form::select('status_id', $statuslabel_list , old('status_id'), array('class'=>'select2', 'style'=>'width:100%', 'aria-label'=>'status_id')) }} +

{{ trans('general.status_compatibility') }}

{!! $errors->first('status_id', '') !!}
diff --git a/resources/views/hardware/checkout.blade.php b/resources/views/hardware/checkout.blade.php index 943b4ba79810..6e01c9aa655c 100755 --- a/resources/views/hardware/checkout.blade.php +++ b/resources/views/hardware/checkout.blade.php @@ -82,7 +82,13 @@ {{ trans('admin/hardware/form.status') }}
- {{ Form::select('status_id', $statusLabel_list, $asset->status_id, array('class'=>'select2', 'style'=>'width:100%','', 'aria-label'=>'status_id')) }} + {!! $errors->first('status_id', '') !!}
diff --git a/resources/views/settings/labels.blade.php b/resources/views/settings/labels.blade.php index 33640edbf28a..db20efc0cfa3 100644 --- a/resources/views/settings/labels.blade.php +++ b/resources/views/settings/labels.blade.php @@ -156,7 +156,14 @@ class="table table-striped snipe-table" 'none' => trans('admin/settings/general.none'), ]; @endphp - {{ Form::select('label2_1d_type', $select1DValues, old('label2_1d_type', $setting->label2_1d_type), [ 'class'=>'select2 col-md-4', 'aria-label'=>'label2_1d_type' ]) }} + {!! $errors->first('label2_1d_type', '') !!}

{{ trans('admin/settings/general.label2_1d_type_help') }}. @@ -184,7 +191,14 @@ class="table table-striped snipe-table" 'none' => trans('admin/settings/general.none'), ]; @endphp - {{ Form::select('label2_2d_type', $select2DValues, old('label2_2d_type', $setting->label2_2d_type), [ 'class'=>'select2 col-md-4', 'aria-label'=>'label2_2d_type' ]) }} + {!! $errors->first('label2_2d_type', '') !!}

{{ trans('admin/settings/general.label2_2d_type_help', ['current' => $setting->barcode_type]) }}. @@ -204,7 +218,14 @@ class="table table-striped snipe-table" {{ Form::label('label2_2d_target', trans('admin/settings/general.label2_2d_target'), ['class'=>'control-label']) }}

- {{ Form::select('label2_2d_target', ['hardware_id'=>'/hardware/{id} ('.trans('admin/settings/general.default').')', 'ht_tag'=>'/ht/{asset_tag}'], old('label2_2d_target', $setting->label2_2d_target), [ 'class'=>'select2 col-md-4', 'aria-label'=>'label2_2d_target' ]) }} + {!! $errors->first('label2_2d_target', '') !!}

{{ trans('admin/settings/general.label2_2d_target_help') }}

From 8c37c3375a4bb41b43ac133c60270e6e0a0d0140 Mon Sep 17 00:00:00 2001 From: Marcus Moore Date: Wed, 4 Dec 2024 16:16:49 -0800 Subject: [PATCH 11/28] Convert additional selects --- resources/views/blade/input/select.blade.php | 4 +++- .../views/hardware/quickscan-checkin.blade.php | 16 +++++++++++----- ...ield-set-default-values-for-model.blade.php | 11 ++++++++++- .../livewire/slack-settings-form.blade.php | 18 +++++++++++------- .../views/users/confirm-bulk-delete.blade.php | 12 ++++++++++-- 5 files changed, 45 insertions(+), 16 deletions(-) diff --git a/resources/views/blade/input/select.blade.php b/resources/views/blade/input/select.blade.php index 7bcb11fd99f2..6c1931924e58 100644 --- a/resources/views/blade/input/select.blade.php +++ b/resources/views/blade/input/select.blade.php @@ -2,10 +2,12 @@ 'items', 'selected' => null, 'includeEmpty' => false, + 'forLivewire' => false, ]) From ca30f4e37a15f8274266fafe3957e273f039c1fc Mon Sep 17 00:00:00 2001 From: Marcus Moore Date: Tue, 10 Dec 2024 12:15:47 -0800 Subject: [PATCH 15/28] Convert additional selects --- resources/views/blade/input/select.blade.php | 2 +- resources/views/livewire/importer.blade.php | 24 ++++++++++++------- .../custom_fields_form_bulk_edit.blade.php | 8 +++++-- .../forms/edit/maintenance_type.blade.php | 9 ++++++- 4 files changed, 30 insertions(+), 13 deletions(-) diff --git a/resources/views/blade/input/select.blade.php b/resources/views/blade/input/select.blade.php index 6c1931924e58..ab927efeab71 100644 --- a/resources/views/blade/input/select.blade.php +++ b/resources/views/blade/input/select.blade.php @@ -10,7 +10,7 @@ @if ($forLivewire) data-livewire-component="{{ $this->getId() }}" @endif > @if($includeEmpty) - + @endif @foreach($items as $key => $value) diff --git a/resources/views/livewire/importer.blade.php b/resources/views/livewire/importer.blade.php index 027d9e3dc636..124aa9e8c859 100644 --- a/resources/views/livewire/importer.blade.php +++ b/resources/views/livewire/importer.blade.php @@ -153,15 +153,21 @@ class="col-md-12 table table-striped snipe-table">
- {{ Form::select('typeOfImport', $importTypes, $typeOfImport, [ - 'id' => 'import_type', - 'class' => 'livewire-select2', - 'style' => 'min-width: 350px', - 'data-placeholder' => trans('general.select_var', ['thing' => trans('general.import_type')]), - 'placeholder' => '', //needed so that the form-helper will put an empty option first - 'data-minimum-results-for-search' => '-1', // Remove this if the list gets long enough that we need to search - 'data-livewire-component' => $this->getId() - ]) }} + @if ($typeOfImport === 'asset' && $snipeSettings->auto_increment_assets == 0)

{{ trans('general.auto_incrementing_asset_tags_disabled_so_tags_required') }} diff --git a/resources/views/models/custom_fields_form_bulk_edit.blade.php b/resources/views/models/custom_fields_form_bulk_edit.blade.php index e048b38d0962..5e8966f11bcc 100644 --- a/resources/views/models/custom_fields_form_bulk_edit.blade.php +++ b/resources/views/models/custom_fields_form_bulk_edit.blade.php @@ -24,8 +24,12 @@ @if ($field->element!='text') @if ($field->element=='listbox') - {{ Form::select($field->db_column_name(), $field->formatFieldValuesAsArray(), - old($field->db_column_name(),(isset($item) ? Helper::gracefulDecrypt($field, $item->{$field->db_column_name()}) : $field->defaultValue($model->id))), ['class'=>'format select2 form-control']) }} + @elseif ($field->element=='textarea') @if($field->is_unique) diff --git a/resources/views/partials/forms/edit/maintenance_type.blade.php b/resources/views/partials/forms/edit/maintenance_type.blade.php index 24d008fa2332..d44d81b1f3ef 100644 --- a/resources/views/partials/forms/edit/maintenance_type.blade.php +++ b/resources/views/partials/forms/edit/maintenance_type.blade.php @@ -3,7 +3,14 @@

- {{ Form::select('asset_maintenance_type', $assetMaintenanceType , old('asset_maintenance_type', $item->asset_maintenance_type), ['class'=>'select2', 'aria-label'=>'asset_maintenance_type', 'required' => Helper::checkIfRequired($item, 'asset_maintenance_type') ? true : '', 'style'=> 'width:100%;']) }} + {!! $errors->first('asset_maintenance_type', '') !!}
From 26ee8e34a8bd566595a79fa6848d8dcc22fcbe41 Mon Sep 17 00:00:00 2001 From: Marcus Moore Date: Tue, 10 Dec 2024 13:50:53 -0800 Subject: [PATCH 16/28] Allow passing options via a slot --- resources/views/blade/input/select.blade.php | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/resources/views/blade/input/select.blade.php b/resources/views/blade/input/select.blade.php index ab927efeab71..0feace1d18f2 100644 --- a/resources/views/blade/input/select.blade.php +++ b/resources/views/blade/input/select.blade.php @@ -12,7 +12,11 @@ @if($includeEmpty) @endif - @foreach($items as $key => $value) - - @endforeach + @if($slot->isEmpty()) + @foreach($items as $key => $value) + + @endforeach + @else + {{ $slot }} + @endif From 8622448040d0b473cd7a72c1a98f2f18a561088e Mon Sep 17 00:00:00 2001 From: Marcus Moore Date: Tue, 10 Dec 2024 13:51:17 -0800 Subject: [PATCH 17/28] Convert select in importer --- resources/views/livewire/importer.blade.php | 28 +++++++++++++-------- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/resources/views/livewire/importer.blade.php b/resources/views/livewire/importer.blade.php index 124aa9e8c859..58726d07d1db 100644 --- a/resources/views/livewire/importer.blade.php +++ b/resources/views/livewire/importer.blade.php @@ -242,17 +242,23 @@ class="col-md-12 table table-striped snipe-table">
- - {{ Form::select('field_map.'.$index, $columnOptions[$typeOfImport], @$field_map[$index], - [ - 'class' => 'mappings livewire-select2', - 'placeholder' => trans('general.importer.do_not_import'), - 'style' => 'min-width: 100%', - 'data-livewire-component' => $this->getId() - ],[ - '-' => ['disabled' => true] // this makes the "-----" line unclickable - ]) - }} + + + @foreach($columnOptions[$typeOfImport] as $key => $value) + + @endforeach +
@if (($this->activeFile->first_row) && (array_key_exists($index, $this->activeFile->first_row)))
From 5d4eb365c75296ad415c56ebbef05eb9eb8a24f7 Mon Sep 17 00:00:00 2001 From: Marcus Moore Date: Tue, 10 Dec 2024 13:59:40 -0800 Subject: [PATCH 18/28] Add comments --- resources/views/blade/input/select.blade.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/resources/views/blade/input/select.blade.php b/resources/views/blade/input/select.blade.php index 0feace1d18f2..6da6a9329cf6 100644 --- a/resources/views/blade/input/select.blade.php +++ b/resources/views/blade/input/select.blade.php @@ -1,4 +1,6 @@ @props([ + // items can either be provided as key => value pairs + // or passed in via the default $slot 'items', 'selected' => null, 'includeEmpty' => false, @@ -7,11 +9,12 @@
- +

{{ trans('admin/settings/general.saml_custom_settings_help') }}

{!! $errors->first('saml_custom_settings', '') !!}
From 9c677768f8a85ba6c7edc3e745054285e3ad02c2 Mon Sep 17 00:00:00 2001 From: Marcus Moore Date: Tue, 17 Dec 2024 15:52:27 -0800 Subject: [PATCH 28/28] Use attribute spreading in text area --- resources/views/blade/input/textarea.blade.php | 5 ----- 1 file changed, 5 deletions(-) diff --git a/resources/views/blade/input/textarea.blade.php b/resources/views/blade/input/textarea.blade.php index ba203271b137..85530e059984 100644 --- a/resources/views/blade/input/textarea.blade.php +++ b/resources/views/blade/input/textarea.blade.php @@ -1,7 +1,4 @@ @props([ - 'name', - // use name if id is not provided - 'id' => $id ?? $name, 'value' => '', 'cols' => 50, 'rows' => 10, @@ -9,8 +6,6 @@