Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make EmitterEvent constructor public #876

Closed
fardage opened this issue Feb 12, 2024 · 1 comment
Closed

Make EmitterEvent constructor public #876

fardage opened this issue Feb 12, 2024 · 1 comment
Labels
type:defect Bugs or weaknesses. The issue has to contain steps to reproduce.

Comments

@fardage
Copy link

fardage commented Feb 12, 2024

Describe the bug
We are considering using a custom EventStore as described here. However, the EventStore requires a method with the signature func emittableEvents(withQueryLimit queryLimit: UInt) -> [SnowplowTracker.EmitterEvent]. It seems that initializing EmitterEvent outside of the project is not possible. Am I missing something, or should the protection level of the EventEmitter be changed to public?

Screenshots
image
@fardage fardage added the type:defect Bugs or weaknesses. The issue has to contain steps to reproduce. label Feb 12, 2024
@matus-tomlein
Copy link
Contributor

That is correct, @fardage, thanks for reporting this! We will change the protection level of the constructor in the EmitterEvent in the next patch release.

@mscwilson mscwilson changed the title Persisting events with a custom EventStore Make EmitterEvent constructor public Feb 12, 2024
@mscwilson mscwilson mentioned this issue Feb 12, 2024
Merged
mscwilson added a commit that referenced this issue Feb 13, 2024
@mscwilson
Make EmitterEvent constructor public (close #876)
58fa903 
* Add public to constructor

* Add objc annotation
@mscwilson mscwilson mentioned this issue Feb 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:defect Bugs or weaknesses. The issue has to contain steps to reproduce.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matus-tomlein @fardage