Handle nx monorepo setup #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
maciekstosio
changed the title
filip131311
approved these changes
Nov 17, 2024
| try { | ||
| workspaces = require(packageJsonPath).workspaces; | ||
| require(nxJsonPath); |
There was a problem hiding this comment.
Is there a scenario in which require fails for reasons unrelated to nx.json existence?
Could we use fs.existSync() here?
There was a problem hiding this comment.
Changed in: 7264f94
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #683
This PR adds nx monorepo setup handling by:
Remarks:
iOS fails onseems like problem with my setup (those files were owned by root, reinstalling ruby using rbenv solved the problem)bundle install && bundle exec pod installwithEACCES: Permission deniedI'm investigating if it's related to IDE or something else (i.e. my setup), manualpod installsolves the issueHow Has This Been Tested:
Scenario: Open iOS and Android, check if it builds.
Tested on: