-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Circe] Unclear implicit prioritisation rules #89
Comments
In the test you import |
@joroKr21 makes sense, but when using circe
And it doesn't stay in the way of default codecs. Although, I have to admit, circe does some tricks with |
Sure, but there is also |
support for both would be nice, yes, but I actually also mostly use |
Closing in favor of #107 |
Reproduction:
https://github.com/vpavkin/magnolia/blob/e278256e713ddf3b1aa3365898e930eff168274b/tests/src/main/scala/PriorityIssueTest.scala
Magnolia derivers sometimes override default instances, available from companion. For example, for this type
magnolia will derive coproduct codec for the
List
on rhs of theMap
.This only happens, when default instances are provided by means of being located in companion. If we import them explicitly (with
import io.circe.Encoder._
), then magnolia starts to see them.This is confusing, and hard to notice and debug within deeply nested hierarchies.
The text was updated successfully, but these errors were encountered: