Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading wrapper upon XHR request #1518

Closed
flyfy1 opened this issue Oct 13, 2016 · 4 comments
Closed

Loading wrapper upon XHR request #1518

flyfy1 opened this issue Oct 13, 2016 · 4 comments

Comments

@flyfy1
Copy link
Contributor

flyfy1 commented Oct 13, 2016

Currently, in solidus_backend/app/assets/javascripts/spree/backend/progress.coffee, it listens to ajax request globally. Whenever there's a AJAX request, the progress bar would show, something like this:

image

and this progress bar as a overlay would stop any activities on the backend interface.

When I was trying to provide a Direct File Upload from the Admin Backend, I build something like this:

image

The idea as to let user upload images async.

However, the issue is that.. when a image is uploaded, the Loading would popup, and disable user from doing anything, until the upload is done (i.e., the AJAX request completes).

Any idea on how to solve this issue?

@mtomov
Copy link
Contributor

mtomov commented Oct 21, 2016

I would love to see the direct image upload land in core of solidus! It's such a pain to upload images!

@tvdeyen I know you'd share my suffering, so just pinging you for solidarity : )

@tvdeyen
Copy link
Member

tvdeyen commented Oct 21, 2016

@mtomov you have my full solidarity. I would like to port Alchemys image upload over to Solidus. It's heavily based on https://github.com/blueimp/jQuery-File-Upload. Will see if I can free some time these days. The current image upload is just ridiculous, but as many stores don't even use the build in image solution and use services like Cloudinary, there was not much demand for a better solution yet. But anyway, this needs to be fixed.

@flyfy1 I don't see an easy solution. As others will also be bothered by this we should think about replacing this with a custom trigger or event that all our own XHR requests call when we do expensive stuff. Any thoughts @jhawthorn?

@aitbw
Copy link
Contributor

aitbw commented Feb 26, 2019

I think this can be closed as per #1553, can you confirm this @kennyadsl ?

@tvdeyen
Copy link
Member

tvdeyen commented Feb 26, 2019

Yes. Thanks for that find.

@tvdeyen tvdeyen closed this as completed Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants