This repository has been archived by the owner on Sep 30, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 137
Update eonasdan-bootstrap-datetimepicker to current version 4.0 #138
Comments
Just a short note to myself for the available options: |
Not sure about the BC breaks, I guess we'll have to try it out. Feel free to submit a PR with the updated version if you'd like :) |
Did you continue with this? I tried setting up v4 of the datetimepicker, but this won't work out of the box. And there will be BC breaks, for example in the current way there is a option Other options have other names or work slightly differently and have different default values like null/false. How would you like to continue with this ? Should a PR with BC breaks be created ? |
At least we need a full list of options that have changed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
As mentioned by @afurculita in issue #115 (comment) version 4.0 of the
eonasdan-bootstrap-datetimepicker
has been released:This version includes new features like the
calendarWeek
options:But they also mention some BC:
Can someone tell if these BC are relevant to the
SonataCoreBundle
?If not I could create the PR for the
bower.json
file:https://github.com/sonata-project/SonataCoreBundle/blob/master/bower.json#L8
Changing dependencies from
"eonasdan-bootstrap-datetimepicker": "3.1.3"
to"eonasdan-bootstrap-datetimepicker": "4.0.0"
.Not sure if the version by @Bladrak is a better solution linking the
latest
version:Then I would create a PR on the docs for the new options.
The text was updated successfully, but these errors were encountered: