Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernized packaging needed #3

Closed
dgw opened this issue Jun 5, 2024 · 1 comment
Closed

Modernized packaging needed #3

dgw opened this issue Jun 5, 2024 · 1 comment
Assignees
Milestone

Comments

@dgw
Copy link
Member

dgw commented Jun 5, 2024

I can't get to all of the plugins at once, and we think this is a lesser-used one. But I intend to get to them all Eventually™ and creating an issue that I can self-assign helps with that.

This plugin also doesn't cap the version of sopel it requires to <8, so it won't refuse to work on the new Sopel 8 release or cause pip to silently downgrade an existing bot—which pushes it down the priority list, below other plugins that do do that.

(The project doesn't collect any analytics, so we have only anecdotal evidence and guesses to figure out which plugins are frequently used. Guessing is probably good enough. Probably.)

@dgw dgw self-assigned this Jun 5, 2024
@dgw
Copy link
Member Author

dgw commented Jun 20, 2024

During modernization, the sopel.module import should be replaced by sopel.plugin. Deprecated use of bool with ValidatedAttribute should also be replaced with a BooleanAttribute configuration value:

random_start = types.ValidatedAttribute('random_start', bool, default=False)
"""Whether to randomize the start color."""

These updates will require bumping the minimum Sopel version to 7.1. Use of sopel.module is the reason for a note in the README & PyPI description that the plugin won't work with a future Sopel 9.0; module is scheduled for removal then.

@dgw dgw closed this as completed in 2500c9b Sep 25, 2024
@dgw dgw added this to the 0.2.0 milestone Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant