Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run.sh breaks pip installation #2

Closed
andrewjbennett opened this issue May 23, 2018 · 2 comments
Closed

run.sh breaks pip installation #2

andrewjbennett opened this issue May 23, 2018 · 2 comments
Labels
bug

Comments

@andrewjbennett
Copy link

pypa/pip#5221

I think what happened here is that source failed, and so run.sh ran $PYTHON -m pip install --upgrade pip, which bricked my system pip install.

Maybe change:
source $VENV_NAME/bin/activate

to:
source $VENV_NAME/bin/activate || exit

(or equivalent)
@soraxas soraxas added the bug label May 25, 2018
@soraxas
Copy link
Owner

soraxas commented May 25, 2018

Thanks for letting me know!
I did not considered that before. I will include a better error handling in the scripts :)

@soraxas soraxas mentioned this issue May 25, 2018
Merged
@soraxas
Copy link
Owner

soraxas commented May 27, 2018

Let me know if it stills breaks after the latest commit, I'll close this now.

@soraxas soraxas closed this as completed May 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrewjbennett @soraxas