-
Notifications
You must be signed in to change notification settings - Fork 941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Step delay/event #241
Comments
Great idea! Feel free to submit a pull request. |
I really wanted to make PR for this feature, but I don't use CoffeeScript and it's impossible for me to figure out how to properly write it.
Can you help me with this @sorich87? |
Should it be: setTimeout($.proxy(function() {
this._callOnPromiseDone(promise, showStepHelper);
}, this), step.delay);
return promise; so in CoffeeScript: setTimeout =>
@_callOnPromiseDone promise, showStepHelper
, step.delay
promise Feel free to add me on Skype for more real-time communication. 😃 |
@s7anley still working on this? |
Yes, just didn't have time to finish it. I will try this week. |
Was this feature added? I couldn't find it... Also thought I would mention (since workarounds for issue #233 didn't work for me) how I got around it...
|
@alexcasalboni implemented in |
Awesome! :) @LostCrew |
@alexcasalboni good point on the first one. |
@LostCrew sure, I'm using the workaround you proposed but it's not perfect if you really need a backdrop on a not-yet-visible element, and it always forces me to be aware of the stepIndex (which may vary whenever I update the tour structure, breaking my code). I understand it's not a common case for static pages, but it'd be very useful for a very interactive web application tours (wherever you've ajax or a complex UI). |
@sorich87 Hi, sorry if I'm talking about a non-issue, but I think the delay option is not implemented correctly. I hope I had expressed myself clearly. Thanks in advance for any feedback. |
Would you mind adding a customizable delay option for each step?
This may be required in case some rendering (or toggling) operation needs to be performed for the next-step element to be available (i.e. both in the DOM and visible).
A more complicated alternative could include a custom event binding (on the step element) in order to trigger the relative step.
The text was updated successfully, but these errors were encountered: