Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How do you deselect styles? #2

Closed
nickhamze opened this issue Dec 1, 2018 · 4 comments
Closed

How do you deselect styles? #2

nickhamze opened this issue Dec 1, 2018 · 4 comments

Comments

@nickhamze
Copy link
Member

nickhamze commented Dec 1, 2018 •
edited
Loading

This also brings up an issue that effects Ghostwriter as well but how do you remove styles?

Do we need to add a no style option? I thought that if I clicked on the style again it would remove it but it seems like once I add the style I can't unselect it.
@nickhamze
Copy link
Member Author

Found a similar issue in the Gutenberg issues:
WordPress/gutenberg#11613

@jrtashjian
Copy link
Contributor

Yeah, this is something that needs to be resolved in Gutenberg/Core. We could add a "Default" style to pick up the slack which is the suggestion I've seen. I'm not sure how Gutenberg will handle conflicts with multiple default styles being defined by different plugins but I guess we'll see!

@jrtashjian
Copy link
Contributor

It looks like if there are multiple styles defined exactly the same, no errors are thrown within Gutenberg. We'll just have to remove our own default once the UX is fixed in Gutenberg.

@jrtashjian
Copy link
Contributor

Resolved in 4799ddb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nickhamze @jrtashjian