-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): added helmet, rate limit in sequence when respective configs are present #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: RPMS-1734
sf-kansara
changed the title
feat(core): added helmet in sequence when helmet config is present
feat(core): added helmet, rate limit in sequence when respective configs are present
Dec 10, 2020
samarpan-b
requested changes
Dec 10, 2020
RPMS-1734
RPMS-1734
RPMS-1734
RPMS-1734
RPMS-1734
RPMS-1734
RPMS-1734
RPMS-1734
Kudos, SonarCloud Quality Gate passed! |
samarpan-b
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RPMS-1734
Description
Added logic to use loopback4-helmet, loopback4-ratelimiter in secure sequence when "Helmet Config" & "Rate Limiter Config" binding is found and no custom sequence is used. Updated auth-service and in-mail-service to use internal sequence only when custom sequence is not being used.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: