fix(notification-service): update method to fetch user id for notification user #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ication user RD-0
samarpan-b
requested changes
Dec 30, 2020
| @@ -188,7 +191,7 @@ export class NotificationController { | |||
| return notif.receiver.to.map(to => { | |||
| const notifUser = new NotificationUser(); | |||
| notifUser.notificationId = notif.id ?? ''; | |||
| notifUser.userId = to.id; | |||
| notifUser.userId = this.notifUserService.getUserId(to); | |||
There was a problem hiding this comment.
lets move this out of loop. and make this async because this may contain DB hits further. it should take receiver as parameter and return a promise.
There was a problem hiding this comment.
I am planning to send an extra key to the 'receiver.to' which will be used as 'userId'.
samarpan-b
changed the title
samarpan-b
requested changes
Dec 30, 2020
| @@ -8,6 +9,10 @@ export interface IChannelManager { | |||
| ): boolean; | |||
| } | |||
|
|
|||
| export interface INotificationUserManager { | |||
| getNotifUsers(notif: Notification): NotificationUser[]; | |||
There was a problem hiding this comment.
it should return Promise<NotificationUser[]>
BREAKING CHANGE: RD-0 Y
mayank-SFIN571
force-pushed
the
userid-fix
branch
from
0d398f8 to
286be4e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
samarpan-b
approved these changes
Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update method to fetch user id for notification user.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: