Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(user-onboarding): base code for user-onboarding lib #203

Merged
merged 110 commits into from
Jun 9, 2021

Conversation

vaibhavmauryasf
Copy link
Contributor

@vaibhavmauryasf vaibhavmauryasf commented May 11, 2021

Description

Base code of the user-onboarding client
Fixes # (issue)
#173

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@vaibhavmauryasf vaibhavmauryasf changed the title base code for user-onboarding lib feat: base code for user-onboarding lib May 19, 2021
add the default commands for the user incase the user doest not regiter the commands
fix the magic number error in sonar cloud
fix some other code smells
fix the session ID error regarding weak cryptography
change the filter function for removing the extra steps not needed when the tour is run again
fixed some code smells in the code
fixed some code smells in the code
fixed some code smells in the code
fixed some code smell in the code
added the removed steps array for keeping a track of the removed steps so that those
can also be traverses if the tour is resumed from a specific step
fixed some codesmells in the code
fixed some code smells in the code
fixed some linting issues in the code specified in the PR
fixed some code smells in the code
added README for the client
fixed the readme in the client
fix the lerna bootstarp issue
fixed the issues listed by lerna bootstrap
fixed some linting issues specified by the lerna lint
fixed codesmells in the code
fixed some code smells in the code
fixed the linting issues specified by the lerna lint
fixed some linting issues raised by the lerna lint
fixed the lerna bootstrap issue
fixed lerna test issues and code smells
fixed the issues specified by lerna test
fixed issues in lerna test
fixed lerna boot strap error
fixed a typo error in package.json in audit service
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 9, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@akshatdubeysf akshatdubeysf merged commit 8d4d19b into master Jun 9, 2021
@akshatdubeysf akshatdubeysf deleted the user-onboarding-pr branch June 9, 2021 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants