Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notification-service): adds PATCH notification APIs #213

Merged
merged 2 commits into from
May 19, 2021

Conversation

vineet-suri
Copy link
Contributor

@vineet-suri vineet-suri commented May 18, 2021

RFIT-1632

Description

This PR adds PATCH notification APIs.

This is required in scenario of deleting user from app. Certain notification which contain name of deleted user have to be replaced with a generic name.

Fixes # (issue)
https://sourcefuse.atlassian.net/browse/RFIT-1632

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@vineet-suri vineet-suri changed the title fix(notification-service): adds PATCH notification APIs feature(notification-service): adds PATCH notification APIs May 18, 2021
@vineet-suri vineet-suri changed the title feature(notification-service): adds PATCH notification APIs feat(notification-service): adds PATCH notification APIs May 18, 2021
@samarpan-b samarpan-b merged commit 2c20508 into master May 19, 2021
@samarpan-b samarpan-b deleted the RFIT-1632 branch May 19, 2021 06:54
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants