Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(all services): added security property in all the controllers an… #232

Merged
merged 4 commits into from
Jun 30, 2021
Merged

perf(all services): added security property in all the controllers an… #232

merged 4 commits into from
Jun 30, 2021

Conversation

harshitmitSF
Copy link
Contributor

@harshitmitSF harshitmitSF commented Jun 6, 2021 •
edited
Loading

Description

The security property is added to all the services and controllers wherever required.

Fixes # (issue)
#229

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@harshitmitSF harshitmitSF force-pushed the security-add branch 2 times, most recently from 00484ad to 167b457 Compare June 15, 2021 09:22
@harshitmitSF harshitmitSF force-pushed the security-add branch 2 times, most recently from a184cf2 to 05f2ec3 Compare June 29, 2021 09:17
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@akshatdubeysf akshatdubeysf merged commit e37a5a1 into master Jun 30, 2021
@akshatdubeysf akshatdubeysf deleted the security-add branch June 30, 2021 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshatdubeysf akshatdubeysf akshatdubeysf approved these changes

@samarpan-b samarpan-b samarpan-b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harshitmitSF @samarpan-b @akshatdubeysf