Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bpmn-service): fix workflow model audit fields #240

Merged
merged 2 commits into from
Jul 5, 2021
Merged

Conversation

akshatdubeysf
Copy link
Contributor

Description

Fix workflow model audit fields

Fixes GH-239

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@samarpan-b
Copy link
Contributor

fix code smell please


@authenticate(STRATEGY.BEARER)
@authorize({permissions: [PermissionKey.DeleteWorkflow]})
@del(`${basePath}/{id}/{version}`, {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change uri to ${basePath}/{id}/version/{version}

Copy link
Contributor

@samarpan-b samarpan-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix comment

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@samarpan-b samarpan-b merged commit 8558870 into master Jul 5, 2021
@samarpan-b samarpan-b deleted the GH-239 branch July 5, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On creating new workflow by bpmn service created_by and created_on is missing
2 participants