test(notification-service): added unit testcases #264
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
| }); | ||
|
|
||
| function setUp() { | ||
| channelManagerProvider = new ChannelManagerProvider(); |
There was a problem hiding this comment.
can we add some default logic of channel manager in our test case
There was a problem hiding this comment.
added acceptance test cases for adding mock provider
| }); | ||
|
|
||
| function setUp() { | ||
| notificationUserProvider = new NotificationUserProvider(); |
There was a problem hiding this comment.
again do we have any default impl for this ?
There was a problem hiding this comment.
added acceptance test cases for adding mock provider
ashutosh-bansal-2136
force-pushed
the
notification-tests
branch
2 times, most recently
from
8b65127 to
d6a32e4
Compare
| "@sourceloop/core": "^2.0.1", | ||
| "@types/jsonwebtoken": "^8.5.4", |
There was a problem hiding this comment.
types should be moved to dev deps.
packages/core/locales/en.json
Outdated
| @@ -16,5 +16,11 @@ | |||
| "ENOENT": " no such file or directory, open '/home/samarpan/projects/loopback/loopback4-microservice-catalog/services/authentication-service/public/index.html'", | |||
| "The key 'sf.clientAuthentication.currentClient' is not bound to any value in context RequestContext-yWsyEvu3TeGuly75aFbRdg-13 (context": " RequestContext-yWsyEvu3TeGuly75aFbRdg-13, binding: sf.clientAuthentication.currentClient, resolutionPath: controllers.LoginController --> @LoginController.constructor[0])", | |||
| "Client Invalid": "Client Invalid", | |||
| "host is required": "host is required" | |||
| "host is required": "host is required", | |||
There was a problem hiding this comment.
these changes are not needed.
ashutosh-bansal-2136
force-pushed
the
notification-tests
branch
from
d7cdb7b to
745a7dc
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
gh-242
Description
Unit test cases added.
Fixes #242
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: