Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bpmn-service): fix multiple workflow worker registration issue #268

Merged
merged 4 commits into from
Jul 19, 2021

Conversation

akshatdubeysf
Copy link
Contributor

Description

fix multiple workflow worker registration issue

Fixes #267

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@akshatdubeysf akshatdubeysf changed the title fix(bpmn-service): fix(bpmn-service): fix multiple workflow worker registration issue Jul 19, 2021
@@ -13,12 +13,13 @@ export class WorkerRegisterFnProvider implements Provider<WorkerRegisterFn> {
value(): WorkerRegisterFn {
return async (workflowName, topic, command) => {
let workerMap = await this.workerMapGetter();
if (!workerMap) {
workerMap = {};
}
if (workerMap?.[workflowName]) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this '?'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@samarpan-b samarpan-b merged commit a29493c into master Jul 19, 2021
@samarpan-b samarpan-b deleted the GH-267-fix branch July 19, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow service: Default implemenation of the RegisterWorker provider only register workers for one workflow.
2 participants