Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(search-service): add search service, with a sandbox example #341

Merged
merged 4 commits into from
Oct 24, 2021
Merged

feat(search-service): add search service, with a sandbox example #341

merged 4 commits into from
Oct 24, 2021

Conversation

akshatdubeysf
Copy link
Contributor

Description

add search service that can be configured with multiple models.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@akshatdubeysf akshatdubeysf force-pushed the search branch 3 times, most recently from c91791b to 94010c9 Compare September 21, 2021 07:26
@akshatdubeysf akshatdubeysf force-pushed the search branch 2 times, most recently from 36ca43d to 33c434f Compare September 23, 2021 13:12
@akshatdubeysf
feat(search-service): add search service, with a sandbox example
c3de9d9 
add search service that can be configured be multiple models |

GH-0
@akshatdubeysf akshatdubeysf force-pushed the search branch 10 times, most recently from b2c7151 to 6d15bea Compare October 4, 2021 11:37
@akshatdubeysf akshatdubeysf force-pushed the search branch 11 times, most recently from 1c1cf86 to 7064e21 Compare October 20, 2021 16:20
@akshatdubeysf akshatdubeysf force-pushed the search branch 5 times, most recently from 45553d5 to 86fc4e1 Compare October 21, 2021 20:31
@samarpan-b samarpan-b merged commit 501513c into master Oct 24, 2021
@samarpan-b samarpan-b deleted the search branch October 24, 2021 19:44
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.1% 1.1% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeshamavani yeshamavani Awaiting requested review from yeshamavani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akshatdubeysf @samarpan-b