Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(README): updating readme file for services #613

Merged
merged 3 commits into from
May 10, 2022
Merged

docs(README): updating readme file for services #613

merged 3 commits into from
May 10, 2022

Conversation

parul147
Copy link
Contributor

Description

updating readme file for services

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@parul147 parul147 added the documentation Improvements or additions to documentation label Mar 19, 2022
@parul147 parul147 self-assigned this Mar 19, 2022
@parul147 parul147 force-pushed the readme-file-updates branch 8 times, most recently from bc68087 to 39796d4 Compare March 20, 2022 12:31
@parul147 parul147 marked this pull request as ready for review March 20, 2022 12:32
@parul147 parul147 force-pushed the readme-file-updates branch 5 times, most recently from 0624059 to d10e0f1 Compare March 20, 2022 12:46
samarpan-b
samarpan-b requested changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@samarpan-b samarpan-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need some illustrations or diagrams for each service as well

README.md Show resolved Hide resolved
packages/cli/README.md Outdated Show resolved Hide resolved
@parul147 parul147 force-pushed the readme-file-updates branch from d10e0f1 to d134acb Compare April 11, 2022 13:33
@parul147 parul147 force-pushed the readme-file-updates branch from d134acb to 5fc03ae Compare April 12, 2022 13:30
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@akshatdubeysf akshatdubeysf merged commit b761645 into master May 10, 2022
@akshatdubeysf akshatdubeysf deleted the readme-file-updates branch May 10, 2022 06:03
@snyk-bot snyk-bot mentioned this pull request Jun 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samarpan-b samarpan-b samarpan-b requested changes

@akshatdubeysf akshatdubeysf akshatdubeysf approved these changes

Assignees

@parul147 parul147

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parul147 @samarpan-b @akshatdubeysf