fix(notification-service): fix for notification user entry #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samarpan-b
requested changes
Nov 3, 2020
| notifUser.isRead = false; | ||
| await this.notificationUserRepository.create(notifUser); | ||
|
|
||
| const receiversToCreate = notif.receiver.to.map(to => { |
|
|
||
| const receiversToCreate = notif.receiver.to.map(to => { | ||
| const notifUser = new NotificationUser(); | ||
| notifUser.notificationId = notif.id || ''; |
There was a problem hiding this comment.
to bypass type check failure
| const notifUser = new NotificationUser(); | ||
| notifUser.notificationId = notif.id || ''; | ||
| notifUser.userId = to.id; | ||
| notifUser.isRead = false; |
There was a problem hiding this comment.
no need to set. there is default
mayank-SFIN571
force-pushed
the
notif-user-fix
branch
from
08bf01c to
220eae6
Compare
mayank-SFIN571
force-pushed
the
notif-user-fix
branch
4 times, most recently
from
e3a3596 to
feee76f
Compare
samarpan-b
requested changes
Nov 3, 2020
| notifUser.isRead = false; | ||
| await this.notificationUserRepository.create(notifUser); | ||
|
|
||
| if (!notif.receiver || !notif.receiver.to) { |
There was a problem hiding this comment.
move this null check to inside the new function
mayank-SFIN571
force-pushed
the
notif-user-fix
branch
from
feee76f to
aa6f3d9
Compare
samarpan-b
approved these changes
Nov 3, 2020
mayank-SFIN571
force-pushed
the
notif-user-fix
branch
from
aa6f3d9 to
e9e6d4c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFIT-568
Description
Notification user creation issue resolved .
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: