-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(authentication-service): LB4-Authorization dependancy upgrade #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vineet-suri
reviewed
Nov 10, 2020
vineet-suri
requested changes
Nov 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sonar issue also needs fix.
Updated controller authorize decorator RPMS-413
Updated loopback4-authorization to 3.1.1, and added loopback/metadata in in-mail and video conferencing services, as test cases were failing. BREAKING CHANGE: Loopback4-authorization authorize metadata changes RPMS-413
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
mlakdawala-sf
changed the title
feat(authentication-service): casbin integration
feat(authentication-service): LB4-Authorization dependancy upgrade
Nov 11, 2020
vineet-suri
approved these changes
Nov 11, 2020
mlakdawala-sf
added a commit
to mlakdawala-sf/loopback4-microservice-catalog
that referenced
this pull request
Nov 14, 2020
feat(authentication-service): LB4-Authorization dependancy upgrade (sourcefuse#92)
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RPMS-413
Description
Added UserLevelResource for storing resource based for route authentication, added allowed user resources in JWT, which can be used in casbin providers to add custom logic as per need, and UserLevelResourceRepository for building custom logic.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: