From 2970e98109103336ecf04989c1602d69e498aae7 Mon Sep 17 00:00:00 2001 From: Deepika Mahindroo Date: Sat, 16 Mar 2024 11:52:50 +0530 Subject: [PATCH] test(core): removed comments removed extra comments GH-78 --- .../src/lib/builder/group/group.component.spec.ts | 8 +------- .../nodes/abstract-workflow-action.class.spec.ts | 12 +++++------- .../services/abstract-builder-service.class.spec.ts | 8 -------- .../classes/statement/statement-node.class.spec.ts | 4 ++-- .../src/lib/errors/base.error.spec.ts | 1 - .../lib/interfaces/link-strategy.interface.spec.ts | 12 ++---------- .../elements/tasks/trigger-on-add-item.task.spec.ts | 4 +--- .../tasks/trigger-when-column-changes.task.spec.ts | 4 +--- .../create/basic-interval-create.strategy.spec.ts | 5 ----- .../create/gateway-create.strategy.spec.ts | 6 ++---- .../lib/services/statement/groups/and.group.spec.ts | 2 +- .../lib/services/statement/groups/or.group.spec.ts | 2 +- 12 files changed, 16 insertions(+), 52 deletions(-) diff --git a/projects/workflows-creator/src/lib/builder/group/group.component.spec.ts b/projects/workflows-creator/src/lib/builder/group/group.component.spec.ts index 0eaa869..6bdc08d 100644 --- a/projects/workflows-creator/src/lib/builder/group/group.component.spec.ts +++ b/projects/workflows-creator/src/lib/builder/group/group.component.spec.ts @@ -69,11 +69,9 @@ describe('GroupComponent', () => { let nodeServiceSpy: any; beforeEach(async () => { const nodeServiceMock = { - getActions: () => [], // Implement a mock method to return an empty array or mock data + getActions: () => [], getEvents: () => [], getNodeByName: eventStub, - // getIdentifier: () => 'OnChangeEvent', - getGroupByName: () => {}, getGroups: () => [], mapInputs: () => [], @@ -184,16 +182,12 @@ describe('GroupComponent', () => { expect(popper.hide).toHaveBeenCalled(); }); - // Create a mock class for NgxPopperjsContentComponent - - // Create a spy object to mock the methods of NgxPopperjsContentComponent const popperSpy = jasmine.createSpyObj('NgxPopperjsContentComponent', [ 'show', 'hide', ]); it('should hide the previous popper and show the current popper', () => { - // Arrange const event = new MouseEvent('click'); component.prevPopperRef = popperSpy; // Assign the spy object to prevPopperRef diff --git a/projects/workflows-creator/src/lib/classes/nodes/abstract-workflow-action.class.spec.ts b/projects/workflows-creator/src/lib/classes/nodes/abstract-workflow-action.class.spec.ts index 759b09c..16871c9 100644 --- a/projects/workflows-creator/src/lib/classes/nodes/abstract-workflow-action.class.spec.ts +++ b/projects/workflows-creator/src/lib/classes/nodes/abstract-workflow-action.class.spec.ts @@ -3,27 +3,25 @@ import {WorkflowAction} from './abstract-workflow-action.class'; import {AbstractWorkflowNode} from './abstract-workflow-node.class'; describe('WorkflowAction', () => { - let workflowAction: WorkflowAction; // You may replace 'any' with a specific type for your test + let workflowAction: WorkflowAction; beforeEach(() => { class MockAbstractWorkflowNode extends AbstractWorkflowNode { type = NodeTypes.ACTION; statement: string; prompts: string[]; - state: any; // Replace 'any' with your specific state type + state: any; name: string; - groupType: string; // Add groupType property - groupId: string; // Add groupId property + groupType: string; + groupId: string; elements: any[]; isElseAction: boolean; getIdentifier(): string { - // Implement the getIdentifier method as needed return `${this.groupId}_${this.name}`; } - // Mock other necessary methods or properties of AbstractWorkflowNode } - workflowAction = new MockAbstractWorkflowNode(); // You need to implement MockWorkflowAction class + workflowAction = new MockAbstractWorkflowNode(); }); it('should have type set to NodeTypes.ACTION', () => { diff --git a/projects/workflows-creator/src/lib/classes/services/abstract-builder-service.class.spec.ts b/projects/workflows-creator/src/lib/classes/services/abstract-builder-service.class.spec.ts index 7eb49ef..0eade52 100644 --- a/projects/workflows-creator/src/lib/classes/services/abstract-builder-service.class.spec.ts +++ b/projects/workflows-creator/src/lib/classes/services/abstract-builder-service.class.spec.ts @@ -3,7 +3,6 @@ import {AbstractBaseGroup} from '../nodes'; import {BuilderService} from './abstract-builder-service.class'; import {RecordOfAnyType} from '../../types'; -// Mock implementation of BuilderService for testing class MockBuilderService extends BuilderService< E, S @@ -40,27 +39,20 @@ describe('BuilderService', () => { let builderService: BuilderService; beforeEach(() => { - // Create an instance of the BuilderService with the mock implementation builderService = new MockBuilderService(); }); it('should build and return a string', async () => { - // Create dummy statements const statement: Statement = {} as any; const elseStatement: Statement = {} as any; - // Call the build method const result = await builderService.build(statement, elseStatement); - // Check if the result is a string expect(typeof result).toBe('string'); }); it('should restore and return the expected structure', async () => { - // Call the restore method const restoredModel = await builderService.restore('mocked-model'); - - // Check if the returned object has the expected properties expect(restoredModel.actions).toBeDefined(); expect(restoredModel.elseActions).toBeDefined(); expect(restoredModel.events).toBeDefined(); diff --git a/projects/workflows-creator/src/lib/classes/statement/statement-node.class.spec.ts b/projects/workflows-creator/src/lib/classes/statement/statement-node.class.spec.ts index f42da51..e93f10b 100644 --- a/projects/workflows-creator/src/lib/classes/statement/statement-node.class.spec.ts +++ b/projects/workflows-creator/src/lib/classes/statement/statement-node.class.spec.ts @@ -9,11 +9,11 @@ describe('StatementNode', () => { let mockNode: WorkflowNode; beforeEach(() => { - // Create mock instances for WorkflowElement and WorkflowNode + // mock instances for WorkflowElement and WorkflowNode mockElement = {} as WorkflowElement; mockNode = {} as WorkflowNode; - // Create a new StatementNode instance before each test + // a new StatementNode instance before each test statementNode = new StatementNode(mockElement, mockNode); }); diff --git a/projects/workflows-creator/src/lib/errors/base.error.spec.ts b/projects/workflows-creator/src/lib/errors/base.error.spec.ts index c223683..bef3914 100644 --- a/projects/workflows-creator/src/lib/errors/base.error.spec.ts +++ b/projects/workflows-creator/src/lib/errors/base.error.spec.ts @@ -6,7 +6,6 @@ describe('Error Classes', () => { let missingError: MissingError; beforeEach(() => { - // Create instances of error classes before each test invalidEntityError = new InvalidEntityError('testEntity'); notProvidedError = new NotProvided('testName'); missingError = new MissingError('testName'); diff --git a/projects/workflows-creator/src/lib/interfaces/link-strategy.interface.spec.ts b/projects/workflows-creator/src/lib/interfaces/link-strategy.interface.spec.ts index 323909b..96f977a 100644 --- a/projects/workflows-creator/src/lib/interfaces/link-strategy.interface.spec.ts +++ b/projects/workflows-creator/src/lib/interfaces/link-strategy.interface.spec.ts @@ -2,9 +2,7 @@ import {StatementNode} from '../classes'; import {WorkflowElement} from '../classes/element/abstract-element.class'; import {LinkStrategy} from './link-strategy.interface'; -// Mock class for WorkflowElement class MockWorkflowElement extends WorkflowElement { - // Implement any abstract methods with mock implementations tag: any; attributes: any; name: any; @@ -21,30 +19,24 @@ describe('LinkStrategy', () => { let linkStrategy: LinkStrategy; beforeEach(() => { - // Initialize any necessary setup before each test linkStrategy = { - // Mock implementation of the execute method execute: ( element: WorkflowElement, node: StatementNode, ): any[] => { - // Mock implementation, return an empty array for now return []; }, }; }); it('should implement the execute method', () => { - // Ensure that the execute method is implemented expect(linkStrategy.execute).toBeDefined(); }); it('execute method should return an empty array', () => { - // Test the behavior of the execute method - const mockElement = new MockWorkflowElement(); // Create a mock WorkflowElement - const mockNode = new StatementNode(mockElement); // Create a mock StatementNode + const mockElement = new MockWorkflowElement(); + const mockNode = new StatementNode(mockElement); - // Call the execute method and expect it to return an empty array const result = linkStrategy.execute(mockElement, mockNode); expect(result).toEqual([]); }); diff --git a/projects/workflows-creator/src/lib/services/bpmn/elements/tasks/trigger-on-add-item.task.spec.ts b/projects/workflows-creator/src/lib/services/bpmn/elements/tasks/trigger-on-add-item.task.spec.ts index fe52780..fd639ec 100644 --- a/projects/workflows-creator/src/lib/services/bpmn/elements/tasks/trigger-on-add-item.task.spec.ts +++ b/projects/workflows-creator/src/lib/services/bpmn/elements/tasks/trigger-on-add-item.task.spec.ts @@ -11,7 +11,7 @@ describe('TriggerOnAddItem', () => { let triggerOnAddItem: TriggerOnAddItem; let createStrategy: CreateStrategy; let linkStrategy: LinkStrategy; - let env: any; // Mocked environment + let env: any; let utilsService: UtilsService; beforeEach(() => { @@ -60,6 +60,4 @@ describe('TriggerOnAddItem', () => { it('should have the correct outputs', () => { expect(triggerOnAddItem.outputs).toEqual('outputVariable'); }); - - // Add more test cases as needed }); diff --git a/projects/workflows-creator/src/lib/services/bpmn/elements/tasks/trigger-when-column-changes.task.spec.ts b/projects/workflows-creator/src/lib/services/bpmn/elements/tasks/trigger-when-column-changes.task.spec.ts index c42da40..0a4efc6 100644 --- a/projects/workflows-creator/src/lib/services/bpmn/elements/tasks/trigger-when-column-changes.task.spec.ts +++ b/projects/workflows-creator/src/lib/services/bpmn/elements/tasks/trigger-when-column-changes.task.spec.ts @@ -11,7 +11,7 @@ describe('TriggerWhenColumnChanges', () => { let triggerWhenColumnChanges: TriggerWhenColumnChanges; let createStrategy: CreateStrategy; let linkStrategy: LinkStrategy; - let env: any; // Mocked environment + let env: any; let utilsService: UtilsService; beforeEach(() => { @@ -62,6 +62,4 @@ describe('TriggerWhenColumnChanges', () => { it('should have the correct outputs', () => { expect(triggerWhenColumnChanges.outputs).toEqual('outputVariable'); }); - - // Add more test cases as needed }); diff --git a/projects/workflows-creator/src/lib/services/bpmn/strategies/create/basic-interval-create.strategy.spec.ts b/projects/workflows-creator/src/lib/services/bpmn/strategies/create/basic-interval-create.strategy.spec.ts index 0a5824f..4c4965c 100644 --- a/projects/workflows-creator/src/lib/services/bpmn/strategies/create/basic-interval-create.strategy.spec.ts +++ b/projects/workflows-creator/src/lib/services/bpmn/strategies/create/basic-interval-create.strategy.spec.ts @@ -38,22 +38,17 @@ describe('CreateBasicIntervalStrategy', () => { workflowNode: {state: new Map([['someStateKey', 'mockedStateValue']])}, }; - // Calling the method under test const result = service['parseAttributes'](attrs, node); - // Expectations expect(result).toEqual({someAttr: 'mockedStateValue'}); }); it('should leave non-state reference attributes unchanged', () => { - // Mocking necessary data const attrs: RecordOfAnyType = {someAttr: 'someValue'}; const node: any = {workflowNode: {state: new Map()}}; - // Calling the method under test const result = service['parseAttributes'](attrs, node); - // Expectations expect(result).toEqual(attrs); }); }); diff --git a/projects/workflows-creator/src/lib/services/bpmn/strategies/create/gateway-create.strategy.spec.ts b/projects/workflows-creator/src/lib/services/bpmn/strategies/create/gateway-create.strategy.spec.ts index f7e55a9..5746165 100644 --- a/projects/workflows-creator/src/lib/services/bpmn/strategies/create/gateway-create.strategy.spec.ts +++ b/projects/workflows-creator/src/lib/services/bpmn/strategies/create/gateway-create.strategy.spec.ts @@ -31,12 +31,10 @@ describe('CreateGatewayStrategy', () => { describe('parseAttributes', () => { it('should parse state references in attributes', () => { - const attrs = {}; // Provide mock attributes - const node = {} as BpmnStatementNode; // Provide a mock of BpmnStatementNode + const attrs = {}; + const node = {} as BpmnStatementNode; const parsedAttrs = service['parseAttributes'](attrs, node); - - // Add expectations/assertions here }); }); }); diff --git a/projects/workflows-creator/src/lib/services/statement/groups/and.group.spec.ts b/projects/workflows-creator/src/lib/services/statement/groups/and.group.spec.ts index 6ab9a72..0550137 100644 --- a/projects/workflows-creator/src/lib/services/statement/groups/and.group.spec.ts +++ b/projects/workflows-creator/src/lib/services/statement/groups/and.group.spec.ts @@ -4,7 +4,7 @@ import {AndGroup} from './and.group'; describe('AndGroup', () => { let group: AndGroup; - let localizedStringMap: RecordOfAnyType = {}; // You can add mock localized string data here + let localizedStringMap: RecordOfAnyType = {}; let id = ''; let type = NodeTypes.GROUP; let isElseGroup = false; diff --git a/projects/workflows-creator/src/lib/services/statement/groups/or.group.spec.ts b/projects/workflows-creator/src/lib/services/statement/groups/or.group.spec.ts index b2836b4..34cea9d 100644 --- a/projects/workflows-creator/src/lib/services/statement/groups/or.group.spec.ts +++ b/projects/workflows-creator/src/lib/services/statement/groups/or.group.spec.ts @@ -4,7 +4,7 @@ import {OrGroup} from './or.group'; describe('OrGroup', () => { let group: OrGroup; - let localizedStringMap: RecordOfAnyType = {}; // You can add mock localized string data here + let localizedStringMap: RecordOfAnyType = {}; let id = ''; let type = NodeTypes.GROUP;