-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Improve our loading and saving and editing API for signatures & minhashes #155
Conversation
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
==========================================
+ Coverage 85.31% 85.42% +0.11%
==========================================
Files 13 13
Lines 1879 1894 +15
Branches 52 52
==========================================
+ Hits 1603 1618 +15
Misses 265 265
Partials 11 11
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Changes:
copy_and_clear
method to create a new MinHash (make a new MinHash method that creates an empty minhash... #95);subtract_mins
method;load_one_signature
;make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?