-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add --csv output to 'sourmash compare' #217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, waiting for R snippet.
Is this the functionality you wanted in the snippet of R code? Or did you want a plot as well?
|
The R code works, yes? And if you have a quick plot that'd be great but if it's
a lot of work no need.
|
R code works. One would have to point R to their own compare matrix output file, and be in the working directory in which that file resides, but it works. For plotting:
|
thank you @taylorreiter! |
Codecov Report
@@ Coverage Diff @@
## master #217 +/- ##
==========================================
+ Coverage 85.6% 85.67% +0.06%
==========================================
Files 13 13
Lines 1897 1906 +9
Branches 52 52
==========================================
+ Hits 1624 1633 +9
Misses 262 262
Partials 11 11
Continue to review full report at Codecov.
|
@ctb I can write these as functions or as documentation. Everything is in base R except Rtsne
|
thank you! |
Fixes #167.
@taylorreiter @brooksph could one of you try this out and provide a small snippet of R code for reading in the resulting matrix? thx!
make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?