Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identities.IterateMalicious doesn't handle equivocation set for V2 ATXs correctly #6331

Open
ivan4th opened this issue Sep 13, 2024 · 0 comments
Labels

Comments

@ivan4th
Copy link
Contributor

ivan4th commented Sep 13, 2024

Description

The identities.IterateMalicious doesn't check for married ATXs and thus yields the different set of malicious identities that you would get from going over every identity and calling identity.IsMalicious() for it, checking for true.
identities.IterateMalicious is used during warmup.
Related code:

"select (select count(*) from identities where proof is not null) as total, "+
"pubkey from identities where proof is not null", nil, dec); err != nil {

Expected Behavior

identities.IsMalicious should handle equivocation sets correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant