Docker push workflow triggered on PR instead of on merge

[fasmat]

With the introduction of dependabot a small issue popped up; PRs created with dependabot failed their CI builds (e.g. this one: #117)

The reason for that is that dependabot doesn't have access to the same set of secrets as PRs created from others have. So it cannot authenticate against Dockerhub and the build fails.

The question here is should we move the "Docker build & push" step out of the CI workflow and move it into one that is only triggered AFTER the merge of a PR, instead of on every commit? At the moment a new image is released every time the image build has been successful, even if tests failed.

@dshulyak @lrettig @evt

[pigmej]

Yes, it should not be like that ;)

should be fixed.

At the same time. we should spend some time aligning most of the repos to more or less the same methodology.

Building post-merge also have a lot of risks especially for poet. (deps can change between the review and merge, target can change) etc.

[fasmat]

Building post-merge also have a lot of risks especially for poet. (deps can change between the review and merge, target can change) etc.

I still want to build it during the CI step. But not push it to docker hub. When the merge completes build the master branch again and push this to docker hub, but I'm fine with this just serving as a reminder for an aligned CI/CD strategy.

[poszu]

Building the image and pushing it to a registry for every commit/PR is handy for testing purposes - one can later use that image with systests.