Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak import pubkey from ledger - import after password and only if ledger still available #66

Open
monikasmolarek opened this issue Aug 13, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@monikasmolarek
Copy link
Collaborator

Steps:

  1. connect the ledger device correctly,
  2. click settings->manage keys-> import pub key from the ledger,
  3. fill in the name and proceed,
  4. on the password validation step disconnect the ledger - physically unplug the device,
  5. after that provide a correct password
  6. click [import the pub keys from the ledger].

Currently, the pubkey is successfully imported even from a disconnected device.

Expected result:

After physically disconnecting the Ledger device / closing the Spacemesh app / locking the device and providing the correct password, the expected behavior should be: validate the password, handle the disconnection gracefully, and prevent the operation from proceeding with an error indicating the disconnection.
An error message like “Unable to Import Public Keys” should give options to either cancel the operation or retry the connection. The user should not lose any progress made in entering the name and other details, but the import action should be paused until the Ledger is reconnected and the password validated again.

@monikasmolarek monikasmolarek added the bug Something isn't working label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant