Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Mnemonics Verification step #9

Open
monikasmolarek opened this issue May 22, 2024 · 2 comments
Open

Improve Mnemonics Verification step #9

monikasmolarek opened this issue May 22, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@monikasmolarek
Copy link
Collaborator

monikasmolarek commented May 22, 2024

Please, place the missed words on their places appears all the time. I guess it should be displayed only when the verification was not successful - words put in the incorrect places.

And then this message should be more visible (orange?). After an incorrect placement, the user doesn’t know easily what’s wrong, only the "Next" button is disabled.

Also, I think all other words should be hidden for security reasons?

Screenshot 2024-05-22 at 22 39 30

Screenshot 2024-05-22 at 21 51 00

@monikasmolarek monikasmolarek changed the title Please, place the missed words on their places Mnemonics Verification step - display msg and words to correct May 22, 2024
@monikasmolarek monikasmolarek added the enhancement New feature or request label May 22, 2024
@monikasmolarek monikasmolarek changed the title Mnemonics Verification step - display msg and words to correct Mnemonics Verification step - display msg and words visibility to correct May 22, 2024
@brusherru
Copy link
Member

brusherru commented Jun 26, 2024

Well, I can replace this screen with something simpler and not showing other words.
Like 4 dropdowns next to random numbers:

2.   [ east         v ]
5.   [ south        v ]
12.  [ pick a word  v ]
17.  [ pick a word  v ]

But later, after all the mandatory things will be implemented :)

@brusherru brusherru changed the title Mnemonics Verification step - display msg and words visibility to correct Improve Mnemonics Verification step Jun 26, 2024
@monikasmolarek
Copy link
Collaborator Author

I actually think I was being ridiculous or too much focused on details. It's completely unnecessary to change the words presentation anyhow. The messages should be rendered conditionally and made more visible/distinct, but the grid with all the words is perfect. No need to waste time on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants