-
-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support parsing noscript content in script-enabled mode #3231
Support parsing noscript content in script-enabled mode #3231
Conversation
This change adds support for parsing noscript content with the scripting flag enabled. In this case, Gumbo will treat the content of the noscript element as raw text, exactly as the browser would.
Suggestions on a better option name are especially welcome. I didn't want to use something like |
I just realized that I haven't had the html5lib tests running so this is really not ready for review yet. Gotta figure out what I did wrong here first. |
It seems that we're now passing the scripting enabled html5lib tree construction tests. |
This PR should also update the docstring in Let me know if you'd like me to put in any of this work? I'm happy to do as much or as little as you like. ♥ |
The name Or if we want to be funny, |
I did that as well. But I left the existing option name. I'll defer to your experience in API design. |
and update the CHANGELOG
46c2001
to
e3f326a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I added a commit to fix up some of the rdoc formatting (which is famously challenging to write correctly without looking at the generated docs in a browser) and a CHANGELOG entry.
The changelog entry isn't worded perfectly ... I'll fix it in postproduction |
This change adds support for parsing noscript content with the scripting flag enabled. In this case, Gumbo will treat the content of the noscript element as raw text, exactly as the browser would.
What problem is this PR intended to solve?
Closes #3178
Have you included adequate test coverage?
Yes.
Does this change affect the behavior of either the C or the Java implementations?
It adds support for this parsing option to libgumbo only.